Conversation
The SVG was always rendered at 800px because updateWidth() was a no-op
at onMounted() time: the parent component uses a loading gate
(v-if="!loading") that defers RevisionGraph's mount until after an async
fetch, at which point svgRef.value is still null on the first render tick.
Replace window.addEventListener('resize') with a ResizeObserver on the
component root div (containerRef), which fires on initial attach, on
BCollapse open/close, and on window resize. Also add initZoom() to the
revisions watch so zoom is initialised when data arrives after mount.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* V3: Replace last character with whitespace if it's a colon Current implementation causes a trailing colon to be present before URL Path * Fix baseURL helper function If no port used (e.g. serving on port 80 or 443), colon is still present in returned baseURL causing errors. * V3: Update baseURL helper function * Remove initial regex fix for port separator Identified root cause of issue - removing workaround * npm linting * Remove trailing comma from baseURL test in client V2 --------- Co-authored-by: Tim Bradgate <timbradgate@hotmail.co.uk>
github-actions
Bot
added
small-diff
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 213dd10. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 213dd10. |
|
Python Test Results 1 files 1 suites 1m 48s ⏱️ Results for commit 213dd10. |
Playwright E2E Results (chromium)160 tests 160 ✅ 1m 34s ⏱️ Results for commit 213dd10. |
Playwright E2E Results (firefox)160 tests 160 ✅ 1m 37s ⏱️ Results for commit 213dd10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.