Skip to content

Switch from minio to boto3#403

Merged
MarekSuchanek merged 1 commit into
developfrom
deps/minio-boto3
Jul 13, 2026
Merged

Switch from minio to boto3#403
MarekSuchanek merged 1 commit into
developfrom
deps/minio-boto3

Conversation

@MarekSuchanek

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the dsw-storage S3 implementation from the minio Python SDK to AWS’s boto3/botocore, and updates dependency pins across the repo accordingly.

Changes:

  • Replace minio usage in S3Storage with boto3 client calls for bucket checks/creation, uploads, and downloads.
  • Swap package dependencies from minio (and related crypto bindings) to boto3 in dsw-storage and downstream packages.
  • Remove now-unneeded pinned dependencies (e.g., minio, pycryptodome, argon2-*) from multiple requirements files.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
requirements.txt Removes minio and related crypto deps from the root requirements set.
packages/dsw-storage/requirements.txt Replaces minio-related pins with boto3/botocore and their pinned deps.
packages/dsw-storage/pyproject.toml Switches the library dependency from minio to boto3.
packages/dsw-storage/dsw/storage/s3storage.py Reimplements S3 operations using boto3 and adjusts bucket handling logic.
packages/dsw-mailer/requirements.txt Removes minio and related deps; adds/pins boto3 stack.
packages/dsw-document-worker/requirements.txt Removes minio/crypto deps; adds/pins boto3 stack.
packages/dsw-data-seeder/requirements.txt Removes minio/crypto deps; adds/pins boto3 stack.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/dsw-storage/pyproject.toml
Comment thread packages/dsw-storage/dsw/storage/s3storage.py
@MarekSuchanek MarekSuchanek merged commit 8095fbc into develop Jul 13, 2026
54 of 68 checks passed
@MarekSuchanek MarekSuchanek deleted the deps/minio-boto3 branch July 13, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants