Switch from minio to boto3#403
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the dsw-storage S3 implementation from the minio Python SDK to AWS’s boto3/botocore, and updates dependency pins across the repo accordingly.
Changes:
- Replace
miniousage inS3Storagewithboto3client calls for bucket checks/creation, uploads, and downloads. - Swap package dependencies from
minio(and related crypto bindings) toboto3indsw-storageand downstream packages. - Remove now-unneeded pinned dependencies (e.g.,
minio,pycryptodome,argon2-*) from multiple requirements files.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Removes minio and related crypto deps from the root requirements set. |
| packages/dsw-storage/requirements.txt | Replaces minio-related pins with boto3/botocore and their pinned deps. |
| packages/dsw-storage/pyproject.toml | Switches the library dependency from minio to boto3. |
| packages/dsw-storage/dsw/storage/s3storage.py | Reimplements S3 operations using boto3 and adjusts bucket handling logic. |
| packages/dsw-mailer/requirements.txt | Removes minio and related deps; adds/pins boto3 stack. |
| packages/dsw-document-worker/requirements.txt | Removes minio/crypto deps; adds/pins boto3 stack. |
| packages/dsw-data-seeder/requirements.txt | Removes minio/crypto deps; adds/pins boto3 stack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1798514 to
12d035e
Compare
12d035e to
cc0ee07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.