Forge: persist sanitized fingerprint signatures - #14
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
There was a problem hiding this comment.
Pull request overview
This PR adds durable storage for sanitized, structural “signature” data keyed by fingerprint, enabling later aggregation to explain historical patterns without persisting raw commands or source content. It also introduces migration support for legacy v2 state blobs and adds validation to keep the catalog bounded and non-leaky.
Changes:
- Adds
fingerprintCatalogto persisted Forge state (schema + docs) and migrates legacy v2 state without the field. - Restores signatures from the catalog during aggregation and rebuilds a bounded catalog from retained evidence.
- Introduces validation and tests covering catalog shape, fingerprint consistency, and secret-shaped value rejection.
Show a summary per file
| File | Description |
|---|---|
| plugins/repo-dreamer/skills/repository-skill-forge/tests/test_state_catalog.py | New unit tests covering migration, restoration, secret-shaped rejection, key mismatch, and catalog size limits. |
| plugins/repo-dreamer/skills/repository-skill-forge/SKILL.md | Documents the new fingerprintCatalog field and its purpose/behavior. |
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/issue-state.py | Adds fingerprintCatalog field support, legacy migration defaulting, and deep catalog validation + expanded secret/local-path detection. |
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/aggregate-primitives.py | Restores signatures from the catalog into evidence, builds a bounded catalog for persistence, and writes it into next state. |
| plugins/repo-dreamer/skills/repository-skill-forge/assets/schemas.json | Extends the persisted state schema to include fingerprintCatalog. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python3 -m unittest discover -s plugins/repo-dreamer/skills/repository-skill-forge/tests -p 'test_*.py'\n-python3 -m json.tool plugins/repo-dreamer/skills/repository-skill-forge/assets/schemas.json\n- Python compilation andgit diff --check