Add go_package option to all proto files - #14
Closed
cafanasyev wants to merge 2 commits into
Closed
Conversation
Author
|
requires #13 first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protoc-gen-go refuses to generate code for files without a go_package option, so the protos currently cannot be compiled for Go.
This PR adds a go_package option to every .proto file, wrapped in // [START go_declaration] / // [END go_declaration] tags to mirror the existing java_declaration blocks. The import paths follow the repository layout (e.g. github.com/dstl/SAPIENT-Proto-Files/sapient_msg/bsi_flex_335_v2_0;bsiflex335v2). No message definitions are changed.
With this, Go code for both versions generates out of the box: