Add builder option to disable CA certificate pinning#56
Open
mihir-pradhan wants to merge 1 commit into
Open
Conversation
mihir-pradhan
force-pushed
the
ztcapin-505
branch
from
e19b089 to
4aa6201
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mihir-pradhan
force-pushed
the
ztcapin-505
branch
from
4aa6201 to
4e37f42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disableCaPinning()method toClient.Builderthat disables the bundled CA certificate pin set while keeping TLS verification active via the system trust storesetCACerts()— throwsDuoExceptionif both are usedCertificatePinner.DEFAULTin OkHttp when pinning is disabledTest plan
disableCaPinning()builds a client successfullydisableCaPinning()withsetCACerts()throws (both orderings)Relates to: https://cisco-sbg.atlassian.net/browse/ZTCAPIN-505
🤖 Generated with Claude Code