Add method for removing redundant nodes#571
Open
arcondello wants to merge 27 commits into
Open
Conversation
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
2 times, most recently
from
4dab596 to
a8040b8
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
a8040b8 to
82cc356
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
56195c1 to
57638a8
Compare
In C++20 Node::operator==(const Node&) const is amibiguous because either order is valid.
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
39fb39d to
055fe62
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
ee71c02 to
770a9cb
Compare
This requires some fiddling, see https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members for the why.
arcondello
commented
Jul 3, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
261d2d6 to
98e4bd0
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
98e4bd0 to
47e1be7
Compare
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
90386b6 to
cd107a0
Compare
arcondello
commented
Jul 6, 2026
| virtual bool equal_to(const Derived& rhs) const = 0; | ||
| }; | ||
|
|
||
| /// Overload for EqualityMixin that does not require a class-specific equal_to() |
Member
Author
There was a problem hiding this comment.
A doubt I have is whether these two overloads are different enough that they should actually be given different names 🤔
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
42a0edd to
f7a75d1
Compare
arcondello
commented
Jul 9, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
4e887e4 to
f643bca
Compare
Member
Author
|
As a note: I didn't try to be inclusive about the |
arcondello
commented
Jul 10, 2026
arcondello
force-pushed
the
feature/node-equality-and-successor-transfer
branch
from
212caf4 to
d0dd3d3
Compare
fastbodin
reviewed
Jul 13, 2026
fastbodin
left a comment
fastbodin
left a comment
Collaborator
There was a problem hiding this comment.
Managed to work through all files excluding the test files. Thought I would upload these comments before moving onto them.
| >>> model = Model() | ||
| ... | ||
| >>> x = model.integer(5) | ||
| ... |
Collaborator
There was a problem hiding this comment.
Nit: I find that the ... do not add much to the example. Additionally, most of the other examples do not include .... Am I missing something?
| if (not dropped(uptr)) continue; | ||
|
|
||
| // Remove the node from its predecessor's successor vectors. | ||
| // This very leaves the node in an invalid state, very briefly |
Collaborator
There was a problem hiding this comment.
Suggested change
| // This very leaves the node in an invalid state, very briefly | |
| // This leaves the node in an invalid state, very briefly |
Comment on lines
+378
to
+379
|
|
||
| index -= 1; |
Collaborator
There was a problem hiding this comment.
// If we haven't found the Array* we want to replace, then "normalize"
// the index so that it looks like it would if `initial_` wasn't an array.
| assert(array_ptr != nullptr); | ||
| assert(std::ranges::equal(array_ptrs_[index]->shape(), array_ptr->shape())); | ||
|
|
||
| assert(0 <= index and static_cast<size_t>(index) < array_ptrs_.size()); |
Collaborator
There was a problem hiding this comment.
Nit: Totally fine as-is but could replace with
assert(0 <= index and index) < static_cast<ssize_t>(array_ptrs_.size()));to avoid size_t. 🤷
| void NaryOpNode<BinaryOp>::replace_predecessor_(ssize_t index, Node* node_ptr) { | ||
| Node::replace_predecessor_(index, node_ptr); | ||
|
|
||
| assert(0 <= index and static_cast<size_t>(index) < operands_.size()); |
Collaborator
There was a problem hiding this comment.
See Nits above regarding size_t. Fine with it as is.
| bool UnaryOpNode<UnaryOp>::equal_to(const Node& rhs) const { | ||
| const auto* rhs_ptr = dynamic_cast<const UnaryOpNode*>(&rhs); | ||
| if (rhs_ptr == nullptr) return false; // not same type so not equal | ||
| return this->equal_to(*rhs_ptr); |
Collaborator
There was a problem hiding this comment.
Confirming that I am not sleeping at the wheel. I had to do a double take here 😆
Member
Author
There was a problem hiding this comment.
Probably should change 190 to
const UnaryOpNode* rhs_ptr = dynamic_cast<const UnaryOpNode*>(&rhs);to make it a little clearer what's happening.
Collaborator
There was a problem hiding this comment.
Usually I am fine with auto here, but, in this case, that would actually be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563
AI Generation Disclosure
No AI used.