Unit overhaul 5/5: Update tutorials for the new unit API#225
Merged
Conversation
Regenerate the tutorial and performance-test notebooks and their example data files (fake_simple_data.hdf5, fake_advanced_data.hdf5) to reflect the new x_unit/y_unit API and scipp-backed Q from the unit-system overhaul. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
henrikjacobsenfys
added
[scope] enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## split/02c-unit-rename #225 +/- ##
======================================================
Coverage 98.48% 98.48%
======================================================
Files 53 53
Lines 4037 4037
Branches 697 697
======================================================
Hits 3976 3976
Misses 33 33
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
henrikjacobsenfys
merged commit 3bae91e
into
split/02c-unit-rename
27 of 29 checks passed
Member
Author
|
Note: GitHub auto-marked this merged because its commit was fast-forwarded into the base branch (split/02c-unit-rename). The tutorial updates are not on develop yet — they now ship as part of #224, since the notebooks fail until the new unit API is in place and can't be validated separately. Tracking there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the tutorial notebooks and their generated data for the new unit API (
x_unit/y_unit, scippVariableQ, and theverify_Q_indexbehavior) introduced in the preceding PRs in this stack. Touches onlydocs/docs/tutorials/(20 notebooks + regenerated fake-data HDF5 files).Stack — splitting the monolithic "Unit system overhaul" (#217) into a reviewable series. Merge bottom-up:
developverify_Q_index→split/01-unit-utilsVariablein 1/angstrom →split/02a-verify-q-indexunitintox_unit/y_unit→split/02b-q-variablesplit/02c-unit-rename(this PR)🤖 Generated with Claude Code