Conversation
Mirrors semantics on Objects type block format regarding interaction with the used coordinate type fix formatting
We were using a very old vcpkg revision that attempted to download a version of 7zip that is no longer available. Updating to the latest action version while we're touching the build file Were also experiencing a build failure due to msys2 / gcc being used on Windows, so have added the ilammy/msvc-dev-cmd action to setup an MSVC environment. The build failure was possibly exposing a legitimate issue (using dllimport on template functions), but out of scope for this.
Introduce Tag, TagGroup, TagList wiring in the public API and XML parser/formatter, reuse ProfileList from SADM in ADM Document Review-depth: high Review-reason: Adds new user-visible ADM elements and XML behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move TagList/ProfileList auxiliary copying into shared copy machinery, remap TagGroup references during deepCopy, and centralize TagGroup pruning with template-based remove-side logic. Review-depth: high Review-reason: Alters deep-copy semantics and document remove side effects for TagList references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Introduce loudnessMetadata.renderer support, shared renderer parameter types, and parser/formatter integration with dedicated unit and XML tests. Review-depth: high Review-reason: Adds new ADM element behavior and serialization semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…er interop [copilot] Add authoringInformation and coordinateMode support on audioProgrammeReferenceScreen, wire renderer interop APIs, and integrate parser/formatter/copy behavior with tests. Review-depth: high Review-reason: Introduces new programme metadata structures and cross-element interop behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d parsing [copilot] Adopt weak-reference semantics for ReferenceLayout/renderer references and add forward-reference XML parsing coverage across authoring information, loudness renderer, and stream-format paths. Review-depth: high Review-reason: Changes reference ownership semantics and parser resolution behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Expand deep-copy test coverage for 2076-3 metadata propagation in profile-list handling. Review-depth: medium Review-reason: Test-only change increasing behavioral coverage for copy semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
tagList and profileList seem to work fine with my code. Will check the other parts. |
TagGroups did not compare references, so the same tag could not be added with different references
Was serialised as a required rather than optional parameter, so errored when not present
The attribute is mandatory on an authoring renderer but optional on a loudness renderer per BS.2076-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for:
Many of these new elements reference other elements by ID.
Removing the referenced elements from a document in a way that would otherwise make the document invalid, causes these elements to be removed as well, this can happen recursively in some cases where removing that element causes its parent to also be invalidated.
Copilot was used in this PR, but primarily for re-arranging a long sequence of commits that explored a couple of different approaches, into something a bit more approachable.