Skip to content

Drop the per-lookup price debug log#50

Merged
feruzm merged 1 commit into
mainfrom
chore/drop-price-debug-log
Jul 11, 2026
Merged

Drop the per-lookup price debug log#50
feruzm merged 1 commit into
mainfrom
chore/drop-price-debug-log

Conversation

@feruzm

@feruzm feruzm commented Jul 11, 2026

Copy link
Copy Markdown
Member

GetTokenPrice wrote a line to stdout for every non-USD price lookup — inherited from the Node implementation for behavioral parity and unaffected by the Warning log-level default (it bypassed the logger). With the Node build retired, it was the last hot-path log noise. Responses unchanged; 42 tests green.

GetTokenPrice logged a line for every non-USD price lookup — inherited from
the Node implementation for behavioral parity, and unaffected by the Warning
log-level default since it wrote to stdout directly. With the Node build
retired it is the last remaining hot-path log noise; responses are unchanged.
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@feruzm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80ceeaa8-c54d-4fc6-86b3-39f3190aae23

📥 Commits

Reviewing files that changed from the base of the PR and between ba8a948 and 89bac4c.

📒 Files selected for processing (1)
  • dotnet/EcencyApi/Handlers/WalletApi.Market.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-price-debug-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 11, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes a hot-path market-price debug log.

  • Removes the non-USD Console.WriteLine from GetTokenPrice.
  • Removes the quote-key lookup used only to format that log line.
  • Leaves the price candidate and fallback logic unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
dotnet/EcencyApi/Handlers/WalletApi.Market.cs Removes non-USD price debug output from GetTokenPrice without changing the pricing flow.

Reviews (1): Last reviewed commit: "chore: drop the per-lookup price debug l..." | Re-trigger Greptile

@feruzm feruzm merged commit ad8bc82 into main Jul 11, 2026
5 checks passed
@feruzm feruzm deleted the chore/drop-price-debug-log branch July 11, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant