Cppcheck and GCC build warning fixes by sshedi · Pull Request #65 · ecki/net-tools

sshedi · 2026-05-26T18:53:51Z

This patch series addresses a bunch of items from https://github.com/ecki/net-tools/blob/master/TODO
Please let me know your feedback @ecki

sshedi · 2026-05-26T19:00:56Z

My build host details:

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="45 (Rawhide Prerelease)"
RELEASE_TYPE=development
ID=fedora
VERSION_ID=45
VERSION_CODENAME=""
PRETTY_NAME="Fedora Linux 45 (Rawhide Prerelease)"

And toolchain:

$ rpm -q cppcheck gcc
cppcheck-2.20.1-1.fc45.x86_64
gcc-16.1.1-2.fc45.x86_64

sshedi · 2026-06-09T09:26:08Z

Hi @ecki can you please take these changes?

ecki · 2026-06-10T10:23:34Z

Thanks for the patches, This may take a long time to review

ecki

Looks mostly fine, I am not sure about the explizite breaks, but I am not up to Date with latest Linzers, so if you think they are ok, then keep them, maybe comment all with unreadhable?

I had some questions inline, can you Check, please?

ecki · 2026-07-18T01:55:31Z


    argv += optind;
-    argc -= optind;
+    //argc -= optind;


Isn’t getopt needing this?

By the time control reaches here, getopt is done.

Getopt is called for each Interation and I guess it uses the argc if it needs to Look at followup Parameters

I added braces around the while loop, hope this makes it better.

Ah not needed i was not reading the Code Close enough, but I think we should keep einer Both or none of both, if no Arguments are processed we don’t need it on the other Hand it makes sure the global State reflect the processed options. Increasing only argv has potential for overflows

Ok, found a way to use argc as well.

sshedi · 2026-07-18T06:44:50Z

Looks mostly fine, I am not sure about the explizite breaks, but I am not up to Date with latest Linzers, so if you think they are ok, then keep them, maybe comment all with unreadhable?

I had some questions inline, can you Check, please?

Thanks a lot for spending time on this. I have addressed all of them and responded to few. Please check.

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

ecki · 2026-07-18T19:24:02Z

-	if (ferror(f)) {
-	    perror("/proc/net/sctp/snmp");
+	    if (process_fd2(f, filename)) {
+		    fprintf(stderr, _("%s - parse error\n"), filename);


Hm, that now probably writes two Error lines

Made the process_fd2 similar to process_fd and removed the error message print in process_fd2

ecki

Thanks for seeing that through, will be great if it Passes Werror!

sshedi changed the title ~~Sshedi fixes~~ Cppcheck and GCC build warning fixes May 26, 2026

ecki reviewed Jul 18, 2026

View reviewed changes

sshedi force-pushed the sshedi-fixes branch from 189cafa to e2770bc Compare July 18, 2026 06:42

sshedi requested a review from ecki July 18, 2026 06:44

Add few more files to gitignore

257f850

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

sshedi force-pushed the sshedi-fixes branch from ad65ddd to a005f87 Compare July 18, 2026 18:50

sshedi added 20 commits July 19, 2026 00:31

arp: fix cppcheck issues and gcc build warnings

8978e2f

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

hostname: fix cppcheck issues and gcc build warnings

8528214

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

ifconfig: fix cppcheck issues and gcc build warnings

e887420

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

iptunnel: fix cppcheck issues and gcc build warnings

946a417

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

ipmaddr: fix cppcheck issues and gcc build warnings

5867e88

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

mii-tool: fix cppcheck issues and gcc build warnings

e86fbe6

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

nameif: fix cppcheck issues and gcc build warnings

0d2338f

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

netstat: fix cppcheck issues and gcc build warnings

2d68926

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

plipconfig: fix cppcheck issues and gcc build warnings

6eb79a7

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

rarp: fix cppcheck issues and gcc build warnings

a140972

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

route: fix cppcheck issues and gcc build warnings

d75e74a

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

slattach: fix cppcheck issues and gcc build warnings

c28c2b2

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

statistics: fix cppcheck issues and gcc build warnings

8a8d5d2

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/arcnet: fix cppcheck issues and gcc build warnings

d4b6e3a

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/ax25: fix cppcheck issues and gcc build warnings

b5e1544

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/ddp_gr: fix cppcheck issues and gcc build warnings

6c89b4a

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/ec_hw: fix cppcheck issues and gcc build warnings

5e09cee

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/ether: fix cppcheck issues and gcc build warnings

9e88a7d

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/fddi: fix cppcheck issues and gcc build warnings

cb8d14d

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/hw: fix cppcheck issues and gcc build warnings

85dd10f

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

sshedi added 13 commits July 19, 2026 00:53

lib/ib: fix cppcheck issues and gcc build warnings

b306fdb

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/interface: fix cppcheck issues and gcc build warnings

31475ef

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/ipx_gr: fix cppcheck issues and gcc build warnings

7a206b6

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/loopback: fix cppcheck issues and gcc build warnings

3d78610

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/netrom_gr: fix cppcheck issues and gcc build warnings

550e8b8

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/slip: fix cppcheck issues and gcc build warnings

d469276

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/strip: fix cppcheck issues and gcc build warnings

3d59936

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/tr: fix cppcheck issues and gcc build warnings

c3bfd23

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/unix: fix cppcheck issues and gcc build warnings

6d68025

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/util-ank: fix cppcheck issues and gcc build warnings

ac09500

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/x25: fix cppcheck issues and gcc build warnings

93ef539

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

lib/x25_gr: fix cppcheck issues and gcc build warnings

bf9661d

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

Enforce Werror and Wextra to default CFLAGS

7b8870d

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread arp.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread arp.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread Makefile Outdated

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread netstat.c Outdated

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread netstat.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread netstat.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread rarp.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread rarp.c Outdated

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread route.c

ecki reviewed Jul 18, 2026

View reviewed changes

Comment thread statistics.c Outdated

ecki reviewed Jul 18, 2026

View reviewed changes

sshedi force-pushed the sshedi-fixes branch 2 times, most recently from 8d6650b to 7b8870d Compare July 18, 2026 19:52

Conversation

sshedi commented May 26, 2026

Uh oh!

sshedi commented May 26, 2026

Uh oh!

sshedi commented Jun 9, 2026

Uh oh!

ecki commented Jun 10, 2026

Uh oh!

ecki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sshedi commented Jul 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ecki left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants