model.datatypes: Fix parsing of long and negative XSD years#586
Open
paul-gerber-svg wants to merge 1 commit into
Open
model.datatypes: Fix parsing of long and negative XSD years#586paul-gerber-svg wants to merge 1 commit into
paul-gerber-svg wants to merge 1 commit into
Conversation
…ear values Previously, `_parse_xsd_gyear` and `_parse_xsd_gyearmonth` in `datatypes.py` reject values with more than 4 digits or negative signs. Now, the regexes support an optional minus sign and 4+ digits, and the parsers correctly handle the sign from `match[1]`. Unit tests were added. Fixes eclipse-basyx#566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
_parse_xsd_gyearand_parse_xsd_gyearmonthindatatypes.pyreject values with more than 4 digits or negative signs.Now, the regexes support an optional minus sign and 4+ digits, and the parsers correctly handle the sign from
match[1]. Unit tests were added.Fixes #566