Skip to content

Fix: remove root location enforcement#645

Closed
MaximilianSoerenPollak wants to merge 1 commit into
eclipse-score:mainfrom
MaximilianSoerenPollak:MSP_fix_root_enforcement
Closed

Fix: remove root location enforcement#645
MaximilianSoerenPollak wants to merge 1 commit into
eclipse-score:mainfrom
MaximilianSoerenPollak:MSP_fix_root_enforcement

Conversation

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

📌 Description

We currently enforce the docs macro to only be used in the root build file for no reason as far as I can see.
Removing this will open up a usecase of having multiple docs marcos in the same project.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 656a2178-8f54-443a-aa8d-92939f2a7434
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 5.775s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor Author

This most likely actually will not fix the issue I think.
We should instead add / allow for the name attribute as is common in bazel macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant