Add tsan sanitizer#236
Open
VukPavicRTRK wants to merge 14 commits into
Open
Conversation
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 8, 2026 11:36 — with
GitHub Actions
Failure
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 8, 2026 11:36 — with
GitHub Actions
Failure
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 12, 2026 07:38 — with
GitHub Actions
Failure
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 12, 2026 07:38 — with
GitHub Actions
Failure
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 12, 2026 08:19 — with
GitHub Actions
Failure
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 12, 2026 08:19 — with
GitHub Actions
Failure
VukPavicRTRK
marked this pull request as ready for review
June 12, 2026 08:34
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 15, 2026 07:50 — with
GitHub Actions
Failure
VukPavicRTRK
had a problem deploying
to
workflow-approval
June 15, 2026 07:50 — with
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
June 16, 2026 06:20 — with
GitHub Actions
Failure
NicolasFussberger
had a problem deploying
to
workflow-approval
June 16, 2026 06:20 — with
GitHub Actions
Failure
VukPavicRTRK
requested review from
NicolasFussberger
and removed request for
MaciejKaszynski
June 16, 2026 12:25
VukPavicRTRK
temporarily deployed
to
workflow-approval
June 16, 2026 12:38 — with
GitHub Actions
Inactive
VukPavicRTRK
temporarily deployed
to
workflow-approval
June 16, 2026 12:38 — with
GitHub Actions
Inactive
| "@score_cpp_policies//sanitizers:wrapper", | ||
| ], | ||
| target_compatible_with = ["@platforms//os:linux"], | ||
| visibility = ["//visibility:public"], |
Contributor
There was a problem hiding this comment.
I really appreciate your effort to narrow the scope of ASLR disabling just for the test run.
Does this binary need to be public or can this stay repo-private?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates ThreadSanitizer (TSan) via
score_cpp_policies' shared sanitizer infrastructure, completing the sanitizer rollout started in the earlier ASan/UBSan/LSan PR.Changes
.bazelrc--config=tsan(-fsanitize=thread,-O1,-Wno-tsan)with_debug_symbols//tools/sanitizers:tsan_setarch_wrappertools/sanitizers/*setarch -Rto disable ASLR per test.github/workflows/sanitizers.ymltsanto the sanitizer matrixREADME.mdTest exclusions
process_state_client_ut, and integration testsno-tsanNotes
TSan requires ASLR to be disabled for its shadow memory layout. This is handled automatically via
--run_under, so no host configuration changes are needed in CI or locally.Running locally
bazel test --config=tsan --config=x86_64-linux //score/... //tests/...Closes #233