Skip to content

Add pre-commit config#313

Open
paulquiring wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-pre-commit-config
Open

Add pre-commit config#313
paulquiring wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-pre-commit-config

Conversation

@paulquiring

@paulquiring paulquiring commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Uses score_bazel_tools_cc's clang_format_config and quality_clang_tidy_config
Update format workflow

@github-actions

github-actions Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: d9e91931-df26-4293-8dfb-9e2de26e1ff2
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (39 packages loaded, 10 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2296 targets configured)

Analyzing: target //:license-check (160 packages loaded, 5157 targets configured)

Analyzing: target //:license-check (163 packages loaded, 8270 targets configured)

Analyzing: target //:license-check (166 packages loaded, 8281 targets configured)

Analyzing: target //:license-check (166 packages loaded, 8281 targets configured)

Analyzing: target //:license-check (170 packages loaded, 10290 targets configured)

Analyzing: target //:license-check (170 packages loaded, 10290 targets configured)

Analyzing: target //:license-check (170 packages loaded, 10290 targets configured)

Analyzing: target //:license-check (170 packages loaded, 10290 targets configured)

Analyzing: target //:license-check (171 packages loaded, 10410 targets configured)

Analyzing: target //:license-check (171 packages loaded, 10410 targets configured)

INFO: Analyzed target //:license-check (172 packages loaded, 11914 targets configured).
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 91.810s, Critical Path: 1.94s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@paulquiring paulquiring changed the title add pre commit config Add pre-commit config Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

MaciejKaszynski
MaciejKaszynski suggested changes Jul 14, 2026
View reviewed changes
Comment thread externals/ipc_dropin/include/ipc_dropin/ringbuffer.hpp Outdated
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/

#ifndef IPC_DROPIN_RINGBUFFER_HPP_

@MaciejKaszynski MaciejKaszynski Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifndef IPC_DROPIN_RINGBUFFER_HPP_
#ifndef IPC_DROPIN_RINGBUFFER_HPP_

Comment thread externals/ipc_dropin/include/ipc_dropin/socket.hpp Outdated
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/

#ifndef IPC_DROPIN_SOCKET_HPP_

@MaciejKaszynski MaciejKaszynski Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifndef IPC_DROPIN_SOCKET_HPP_
#ifndef IPC_DROPIN_SOCKET_HPP_

paulquiring
paulquiring commented Jul 15, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated
# all relevant files are currently excluded
exclude: |
(?x)^(
externals/|

@paulquiring paulquiring Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indention

@paulquiring
paulquiring force-pushed the feature/add-pre-commit-config branch from db2ec71 to f81d9d8 Compare July 16, 2026 10:37
MaciejKaszynski
MaciejKaszynski suggested changes Jul 16, 2026
View reviewed changes
Comment thread .clang-format
Comment thread .pre-commit-config.yaml Outdated
name: clang-format
# Run the tool binary directly so pre-commit's staged relative paths work.
# If clang-format cannot be found, the toolchain folder name likely changed.
entry: bazel-bin/external/toolchains_llvm++llvm+llvm_toolchain/clang-format -i

@MaciejKaszynski MaciejKaszynski Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you added a script for the clang-tidy to wrap some stuff for the compile-commands, would it make sense to add the same for format even if it doesn't use the compile-commands might be nice to add the bazel run @llvm_toolchain//:clang-tidy as a backup so that if the toolchain moves like the comment says it would still work.

@paulquiring paulquiring Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format and clang-tidy paths are now resolved using cquery, scrips handle that now.

@paulquiring
paulquiring force-pushed the feature/add-pre-commit-config branch from f81d9d8 to 6fd870b Compare July 17, 2026 07:19
@paulquiring paulquiring mentioned this pull request Jul 17, 2026
Closed
NicolasFussberger
NicolasFussberger reviewed Jul 17, 2026
View reviewed changes
Comment thread .clang-format
@@ -1,48 +1,4 @@
BasedOnStyle: Google
AccessModifierOffset: -2

@NicolasFussberger NicolasFussberger Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all the content no longer required?

NicolasFussberger
NicolasFussberger reviewed Jul 17, 2026
View reviewed changes
Comment thread cr_checker_exclusion

@NicolasFussberger NicolasFussberger Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasFussberger NicolasFussberger NicolasFussberger left review comments
+1 more reviewer
@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@paulquiring paulquiring

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulquiring @NicolasFussberger @MaciejKaszynski