Introduce watchdog into ProcessGroupManager [1/N]: Move watchdog sources#334
Open
cameron-craig-etas wants to merge 3 commits into
Open
Conversation
cameron-craig-etas
requested a deployment
to
workflow-approval
July 17, 2026 14:06 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
July 17, 2026 14:06 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
cameron-craig-etas
requested a deployment
to
workflow-approval
July 17, 2026 14:14 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
July 17, 2026 14:14 — with
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#330
This is part 1 of a number of PRs, to move the watchdog ownership to
ProcessGroupManager.This PR is purely a relocation of source files, and updates to BUILD files to reflect the new layout. I have performed the following steps:
alive_monitor/details/watchdog/*toscore/launch_manager/src/daemon/src/watchdog/, split public vs private interfaces:watchdog/):IWatchdogIf.hpp,IDeviceConfigFactory.hpp.watchdog/details/):WatchdogImpl.{hpp,cpp},DeviceIf.{hpp,cpp},Watchdog.hpp.watchdog/BUILDandwatchdog/details/BUILDfiles.strip_include_prefixto the new pathinclude_prefixso#includelines in consumers do not change (We will update the include paths in a separate PR).visibilityof timers/BUILD to includewatchdog:__subpackages__)