Skip to content

Introduce watchdog into ProcessGroupManager [1/N]: Move watchdog sources#334

Open
cameron-craig-etas wants to merge 3 commits into
eclipse-score:mainfrom
etas-contrib:feature/move-watchdog-to-launch-manager-part-1
Open

Introduce watchdog into ProcessGroupManager [1/N]: Move watchdog sources#334
cameron-craig-etas wants to merge 3 commits into
eclipse-score:mainfrom
etas-contrib:feature/move-watchdog-to-launch-manager-part-1

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

#330

This is part 1 of a number of PRs, to move the watchdog ownership to ProcessGroupManager.

This PR is purely a relocation of source files, and updates to BUILD files to reflect the new layout. I have performed the following steps:

  1. Move files from alive_monitor/details/watchdog/* to score/launch_manager/src/daemon/src/watchdog/, split public vs private interfaces:
    • Public (watchdog/): IWatchdogIf.hpp, IDeviceConfigFactory.hpp.
    • Private (watchdog/details/): WatchdogImpl.{hpp,cpp}, DeviceIf.{hpp,cpp}, Watchdog.hpp.
  2. Add BUILD files:
    • new watchdog/BUILD and watchdog/details/BUILD files.
    • Update strip_include_prefix to the new path
    • preserve include_prefix so #include lines in consumers do not change (We will update the include paths in a separate PR).
    • widen visibility of timers/BUILD to include watchdog:__subpackages__)
  3. Fix consumer BUILD labels

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 69bee73a-ae10-49f3-a110-ba1453daa2e1
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (37 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2767 targets configured)

Analyzing: target //:license-check (152 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (159 packages loaded, 8221 targets configured)

Analyzing: target //:license-check (163 packages loaded, 8263 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[1 / 15] Creating source manifest for //:license.check.license_check; 0s local ... (3 actions, 2 running)
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.651s, Critical Path: 2.53s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant