[TIME] Add ASIL related requirements and rework existing#3020
[TIME] Add ASIL related requirements and rework existing#3020BjoernAtBosch wants to merge 5 commits into
Conversation
|
The created documentation from the pull request is available at: docu-html |
| :status: valid | ||
| :version: 1 | ||
|
|
||
| Usage of the vehicle time base API shall be free from interfrences for the consuming components. |
There was a problem hiding this comment.
I would have a quesitons here
- what FFI means here? which aspect? memory, data, cpu?
- would ut make sense to specify, the API shall provide some funcitonality within the asil-b quality? then it will be out fro the box implicitly
There was a problem hiding this comment.
Hmh - not sure about the "correct wording" here. I thought "FFI" is a wording requiring the denoted part to be qualifiable to not to contain software issues which interfere the parts where it's linked to.
|
|
||
| Note: | ||
| * This does not apply to willful interferences by malicious software components or components in control by malicious actors, which are out of scope of this requirement. | ||
| * The end-to-end quality of the time information provided by the time base API may require components and protocols outside of the scope of this SW-platform to be qualified accordingly (e.g. the respective time master) or at least support this requirement (e.g. time-aware bridges/switches supporting the AUTOSAR Time Synchroization Protocol). |
There was a problem hiding this comment.
why here the Autosar is mentioned?
Shoud it be in general Time aware bridges and switches
There was a problem hiding this comment.
My knowledge is, that "pure" gPTP is not supporting e2e protection of the time sync data. If that shall be supported we need to use the AUTOSAR Time Sync Protocol extension. Also, it is mentioned in the S-CORE feature description to stay compatible to AUTOSAR Adaptive (see https://eclipse-score.github.io/score/main/features/time/index.html#in-vehicle-time-synchronization).
The AUTOSAR time sync protocol is an extension of the gPTP. It does not mean that any extensions need to be used but could be used.
There was a problem hiding this comment.
Will reformulate without mentioning Autosar
| :status: valid | ||
| :version: 1 | ||
|
|
||
| Usage of the absolute time base API shall be free from interfrences for the consuming components. |
There was a problem hiding this comment.
I'm not sure I get the intention of the requirement, coudl you exaplain, what did you want to acheive her?
There was a problem hiding this comment.
In general, the usage of the time API(s) shall be free from interference. In fact, we require ASIL level for the vehicle time only (cuurently), but ASIL applications shall be able to access QM level absolute time without being interfered by using the absolute time API library (if that's separated from the other time API libs at all).
| :status: valid | ||
| :version: 1 | ||
|
|
||
| Usage of the time base APIs shall be free from interfrences for the consuming components. |
There was a problem hiding this comment.
Not sure, what exactly do you mean here.
if we will have the API or access to the time base with qsil-b inegrity, tht will already mean FFI support just out fro mthe iso26262
what do we want to achieve wit hthis one?
There was a problem hiding this comment.
There need to be a requirement what exactly demands that. Current requirements do not demand that yet.
There is stkh_req__dependability__automotive_safety which requests "The SW-platform shall support applications with an automotive safety integrity level up to ASIL-B."
BUT: I think this is requesting the ability in general. It is not explicitly requesting it for each and every feature/component of the platform. If it would, EVERYTING would need to be ASIL. But that is not what is wanted.
That's the reason to explicitly state it here for the time API.
There was a problem hiding this comment.
To - maybe - make it clearer what I want to achieve:
I just want to request that the usage of the API by an application does not lead to any interference of the application code. More concrete: the time library (and its mechanisms used to communicate to the Time Daemon) must not induce any interference if linked to the application code. But this latter, more concrete wording is not suitable on stakeholder level as the implementation details shall not be "visible" here.
I don't want to rate the whole API with an ASIL label. This would (imho) mean, that every element of the API is safety qualified (or at least qualifiable). But I don't think, that this wanted.
For that reason I split the ASIL requirements "in two":
- FFI for using the API
- Safety qualification for selected elements of the API, which also requires additional measures outside the scope of this SW platform
| :safety: QM | ||
| :rationale: Enables the system to compare events from different ECUs chronologically, using the same time base for timestamping ingress and egress frames. | ||
| :status: valid | ||
| :status: invalid |
There was a problem hiding this comment.
Why is it marked as not valid?
There was a problem hiding this comment.
This is a proposal. Imho we should not define such detailed requirements on stakeholder level.
|
|
||
| The **score::time feature** shall provide an API to access the synchronized vehicle time. | ||
|
|
||
| .. feat_req:: Usage of Vehicle Time base API has FFI |
There was a problem hiding this comment.
for me, if API is ASIL-B, the requirement below makes no sense since FFI is implicit, or did i read it wrong ?
There was a problem hiding this comment.
Where is it stated that the API shall be ASIL-B? Furthermore, as I understood it ASIL is a process, not a goal.
There was a problem hiding this comment.
Ah - you mean we should set the safety label of feat_req__time__vehicle_time_time_api to "ASIL"?
But then I think it's unclear what elements are ASIL: Is the usage of the API lib is FFI, or are all provided data ASIL qualified? I guess the latter one is not demanded in general.
| :version: 1 | ||
|
|
||
| The **score::time feature** shall provide an API to read the high precision clock in nanoseconds precision. | ||
| The **score::time feature** shall provide an API to read the high resolution clock in nanoseconds resolution. |
There was a problem hiding this comment.
This can only be fulfilled if supporting OS/HW is there, thus kind of generating AoU toward OS.
| .. stkh_req:: Automotive Safety Integrity Level | ||
| :id: stkh_req__dependability__automotive_safety | ||
| :reqtype: Functional | ||
| :reqtype: Non-Functional |
There was a problem hiding this comment.
guess not part of this PR really ?
There was a problem hiding this comment.
It is. Should it be moved to separate PR?
|
|
||
| Note: | ||
| * This does not apply to willful interferences by malicious software components or components in control by malicious actors, which are out of scope of this requirement. | ||
| * The end-to-end quality of the time information provided by the time base API may require components and protocols outside of the scope of this SW-platform to be qualified accordingly (e.g. the respective time master) or at least support this requirement (e.g. time-aware bridges/switches supporting the AUTOSAR Time Synchroization Protocol). |
There was a problem hiding this comment.
not sure if we can/shall use AUTOSAR here.
There was a problem hiding this comment.
See reply to Valery's comment.
There was a problem hiding this comment.
(Will re-formulate this)
| The SW-platform shall provide access to the current high resolution clock from the system time provider in nanoseconds. | ||
|
|
||
| Note: to which clock the high precision clock is mapped, depends on the system design. | ||
| Note: to which clock the high resolution clock is mapped, depends on the system design. |
There was a problem hiding this comment.
Feels like copy-paste with feature req. Shall we flatten this ?
There was a problem hiding this comment.
How to flatten this without loosing preciseness? If stakeholders want to explicitly have this distinction between the different local clocks it should be in.
Else there could be a single more unspecific requirement just requesting "access to local clocks via unified API" (mainly for enabling mockability).
Co-authored-by: Ryan Steel <str1yok@bosch.com> Signed-off-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com>
Requirements for Time feature:
For that I mainly focused on two areas:
This is a draft PR for now as it requires some discussion
Closes eclipse-score/time#33