chore(ci): run more checks on-pr#3094
Draft
AlexanderLanin wants to merge 3 commits into
Draft
Conversation
|
The created documentation from the pull request is available at: docu-html |
a-zw
reviewed
Jul 17, 2026
| name: PR Checks | ||
|
|
||
| on: | ||
| pull_request: |
Contributor
There was a problem hiding this comment.
pull_request_target:
Otherwise it does not trigger for pull requests from forks (like etas-contrib), does it?
Member
Author
There was a problem hiding this comment.
@a-zw pull_request_target is only required if you want the pull request to have access to secrets. Thats quite difficult to get right. And in this case we dont need it, we only need content: read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running a few checks directly, let's run the full blown mega clever central on-pr workflow