Skip to content

chore(ci): run more checks on-pr#3094

Draft
AlexanderLanin wants to merge 3 commits into
mainfrom
on-pr
Draft

chore(ci): run more checks on-pr#3094
AlexanderLanin wants to merge 3 commits into
mainfrom
on-pr

Conversation

@AlexanderLanin

@AlexanderLanin AlexanderLanin commented Jul 16, 2026

Copy link
Copy Markdown
Member

Instead of running a few checks directly, let's run the full blown mega clever central on-pr workflow

Comment thread .github/workflows/on-pr.yml Fixed
@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

name: PR Checks

on:
pull_request:

@a-zw a-zw Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  pull_request_target:

Otherwise it does not trigger for pull requests from forks (like etas-contrib), does it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-zw pull_request_target is only required if you want the pull request to have access to secrets. Thats quite difficult to get right. And in this case we dont need it, we only need content: read.

See checks, it did trigger:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants