Skip to content

[2113] Fix control nodes migration for existing GV/AFV diagrams#2327

Merged
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/fix/fix_control_node_migration_for_existing_GV_AFV_diagrams
Jul 6, 2026
Merged

[2113] Fix control nodes migration for existing GV/AFV diagrams#2327
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/fix/fix_control_node_migration_for_existing_GV_AFV_diagrams

Conversation

@jerome-obeo

@jerome-obeo jerome-obeo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Due to changes introduced to support graphical control nodes on the AFV diagram background, opening existing GV and AFV diagrams containing control nodes caused those nodes to be rendered both on the diagram background and within the action flow compartment.

This commit fixes this behavior by hiding the extra top-level control nodes, which should remain hidden.

Bug:#2113

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@jerome-obeo jerome-obeo force-pushed the jgo/fix/fix_control_node_migration_for_existing_GV_AFV_diagrams branch from b93f439 to 295980f Compare July 1, 2026 15:02
@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jul 1, 2026
Due to changes introduced to support graphical control nodes on the AFV
diagram background, opening existing GV and AFV diagrams containing
control nodes caused those nodes to be rendered both on the diagram
background and within the action flow compartment.

This commit fixes this behavior by hiding the extra top-level control
nodes, which should remain hidden.

Bug: eclipse-syson#2113
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@jerome-obeo jerome-obeo force-pushed the jgo/fix/fix_control_node_migration_for_existing_GV_AFV_diagrams branch from 295980f to 527c1d5 Compare July 6, 2026 07:54
@AxelRICHARD AxelRICHARD merged commit 0f9f9d9 into eclipse-syson:main Jul 6, 2026
3 checks passed
@jerome-obeo jerome-obeo deleted the jgo/fix/fix_control_node_migration_for_existing_GV_AFV_diagrams branch July 6, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants