Add end_before filter and date-range params to get_events#23
Closed
basil1015 wants to merge 5 commits into
Closed
Conversation
Comment out write tools (create/update/delete/add for events, memos, comments, and label updates) in the tool registry so the server only exposes listing/getting tools. Tool definitions and API methods are kept intact so the write tools can be restored by uncommenting. Also comment out the now-unused imports to satisfy noUnusedLocals, and update the tool-registration test to expect the read-only tool set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TimeTree may return a null name for calendar users (e.g. deactivated members), which made CalendarUserSchema.parse throw and surfaced as "Failed to fetch calendars" in list_calendars. Make the name field optional and nullable, matching the virtual-user and label schemas. Add a regression test asserting getCalendars tolerates a null member name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Read-only build + null calendar_user name fix
- Add startAt/endAt optional params to syncEvents and getEventsByCalendar so the TimeTree sync endpoint receives start_at/end_at query params - Add end_before parameter to get_events MCP tool for symmetric date filtering - Apply both client-side filters (start_after, end_before) regardless of server-side support as a guaranteed fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/client/api.ts:syncEvents/getEventsByCalendar에startAt/endAt파라미터를 추가해 TimeTree sync 엔드포인트에start_at/end_at쿼리 파라미터를 전달src/tools/event-tools.ts:get_events도구에end_before파라미터 추가,start_after/end_before클라이언트 측 필터를 서버 지원 여부와 무관하게 항상 적용Test plan
npm run typecheck통과npm test통과 (기존 12개 테스트 모두 green)get_events호출 시end_before파라미터로 날짜 범위 필터 동작 확인🤖 Generated with Claude Code