fix: hide --input-file and --dry-run on no-input read-only commands#487
Open
margaretjgu wants to merge 1 commit into
Open
fix: hide --input-file and --dry-run on no-input read-only commands#487margaretjgu wants to merge 1 commit into
margaretjgu wants to merge 1 commit into
Conversation
Contributor
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts MegaLinter is graciously provided by OX Security |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378.
GET/HEAD commands with an empty input schema (e.g.
es info) showed--input-fileand--dry-runin--helpeven though both are no-ops there.defineCommandnow takes areadOnlyflag (set from the HTTP method in the es/kb/cloud registration layers) and skips both options when the command is read-only and its input schema has no fields.Write commands with empty schemas keep
--input-filesince loose schemas pass the whole file through as the request body. GET-with-body APIs likees searchkeep both because their schemas have fields.Most of the
docs/cli/schema.jsondiff is thecloudnamespace no longer promoting the two flags to namespace level, plus 64 es/kb commands losing them.