Mark ML controller non-dumpable before accepting commands#3081
Draft
edsavage wants to merge 2 commits into
Draft
Mark ML controller non-dumpable before accepting commands#3081edsavage wants to merge 2 commits into
edsavage wants to merge 2 commits into
Conversation
Same-UID peers in the shared ES/ml-cpp pod could write /proc/<controller-pid>/mem and overwrite access@GOT so a spawn's access(path, X_OK) became dlopen(path, RTLD_LAZY) (elastic/security#12621). Call prctl(PR_SET_DUMPABLE, 0) after logging is up and before opening command pipes; verify with PR_GET_DUMPABLE and fail closed if the boundary cannot be established. No-op on non-Linux platforms where /proc/<pid>/mem is not the concern. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to elastic/security#12621 (HackerOne): the ML controller shared UID
1000with the JVM /pytorch_inferenceand remained dumpable, so a compromised peer could write/proc/<controller-pid>/mem, overwriteaccess@GOT, and turnaccess(path, X_OK)intodlopen(path, RTLD_LAZY)(X_OK == RTLD_LAZY == 1) when handling a spawn command — loading attacker code under the controller’s laxer RuntimeDefault-only seccomp.Fix
After logging is reconfigured and before opening command/output pipes (i.e. before accepting commands):
prctl(PR_SET_DUMPABLE, 0)prctl(PR_GET_DUMPABLE) == 0LOG_FATAL+EXIT_FAILURE) if either step failsNo-op on non-Linux platforms (
/proc/<pid>/memsame-UID writes are the Linux concern).Test plan
/proc/<controller-pid>/statusshowsDumpable: 0(or equivalent).PR_SET_DUMPABLEcannot be applied (manual / mocked).Related: #3078 (
__setstate__pre-load), #3080 (seccomp arch/ABI check).Made with Cursor