Restore missing IA32 7-Zip binary required by install script - #613
Open
oalfroukh wants to merge 4 commits into
Open
Restore missing IA32 7-Zip binary required by install script#613oalfroukh wants to merge 4 commits into
oalfroukh wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The install script (
script/select-7z-arch.js) still attempts to select the IA32 7-Zip binary, butvendor/7z-ia32.exeandvendor/7z-ia32.dllare missing from the repository/package, causing installation to fail when targeting IA32.This PR restores the missing binary required by the existing IA32 installation logic.
Fixes #612
However, these files ares no longer present in the repository/package, causing installation to fail with:
Reproduction
electron-builder26.15.7 (through transitive dependency)The installation fails during the
electron-winstallerinstall script.Adding back
vendor/7z-ia32.exeandvendor/7z-ia32.dllfix the installation and allows the build to complete successfully.This PR restores the missing binary required by the existing IA32 installation logic.