Skip to content

Parenthesize NOT operands in SQL adapters #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 3, 2026
+19 −0
Merged

Parenthesize NOT operands in SQL adapters #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/ecto/adapters/myxql/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,9 @@ if Code.ensure_loaded?(MyXQL) do
defp op_to_binary({:is_nil, _, [_]} = expr, sources, query),
do: paren_expr(expr, sources, query)

defp op_to_binary({:not, _, [_]} = expr, sources, query),
do: paren_expr(expr, sources, query)

defp op_to_binary(expr, sources, query),
do: expr(expr, sources, query)

Expand Down
3 changes: 3 additions & 0 deletions lib/ecto/adapters/postgres/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,6 +1192,9 @@ if Code.ensure_loaded?(Postgrex) do
defp maybe_paren({:is_nil, _, [_]} = expr, sources, query),
do: paren_expr(expr, sources, query)

defp maybe_paren({:not, _, [_]} = expr, sources, query),
do: paren_expr(expr, sources, query)

defp maybe_paren(expr, sources, query),
do: expr(expr, sources, query)

Expand Down
4 changes: 4 additions & 0 deletions lib/ecto/adapters/tds/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,6 +1009,10 @@ if Code.ensure_loaded?(Tds) do
paren_expr(expr, sources, query)
end

defp op_to_binary({:not, _, [_]} = expr, sources, query) do
paren_expr(expr, sources, query)
end

defp op_to_binary(expr, sources, query) do
expr(expr, sources, query)
end
Expand Down
3 changes: 3 additions & 0 deletions test/ecto/adapters/myxql_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,9 @@ defmodule Ecto.Adapters.MyXQLTest do

query = Schema |> select([r], r.x + 2) |> plan()
assert all(query) == ~s{SELECT s0.`x` + 2 FROM `schema` AS s0}

query = Schema |> select([r], (not r.x) < r.y) |> plan()
assert all(query) == ~s{SELECT (NOT (s0.`x`)) < s0.`y` FROM `schema` AS s0}
end

test "is_nil" do
Expand Down
3 changes: 3 additions & 0 deletions test/ecto/adapters/postgres_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,9 @@ defmodule Ecto.Adapters.PostgresTest do

query = Schema |> select([r], r.x + 2) |> plan()
assert all(query) == ~s{SELECT s0."x" + 2 FROM "schema" AS s0}

query = Schema |> select([r], (not r.x) < r.y) |> plan()
assert all(query) == ~s{SELECT (NOT (s0."x")) < s0."y" FROM "schema" AS s0}
end

test "is_nil" do
Expand Down
3 changes: 3 additions & 0 deletions test/ecto/adapters/tds_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,9 @@ defmodule Ecto.Adapters.TdsTest do

query = Schema |> select([r], r.x > 2) |> plan()
assert all(query) == ~s{SELECT s0.[x] > 2 FROM [schema] AS s0}

query = Schema |> select([r], (not r.x) < r.y) |> plan()
assert all(query) == ~s{SELECT (NOT (s0.[x])) < s0.[y] FROM [schema] AS s0}
end

test "is_nil" do
Expand Down
Loading