[html5] Fix argument count for __emscripten_run_callback_on_thread#27264
Merged
Conversation
kripken
approved these changes
Jul 7, 2026
In emscripten-core#25783 (80269bf), _emscripten_run_callback_on_thread was updated to take an event_data_size parameter. However, call sites passing 0 for event data in libhtml5.js and libhtml5_webgl.js were missed and left with 5 arguments instead of 6, causing userData to be passed as event_data_size and user_data to be omitted.
sbc100
force-pushed
the
fix-webgl-callback-args
branch
from
25bc5c9 to
9cf8c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #25783,
_emscripten_run_callback_on_threadwas updated to take an event_data_size parameter. However, call sites passing 0 for event data inlibhtml5.jsandlibhtml5_webgl.jswere missed and left with 5 arguments instead of 6, causinguserDatato be passed asevent_data_sizeanduser_datato be omitted.