[html5] Remove duplication in canvasResizedCallback invocations. NFC#27265
Merged
sbc100 merged 1 commit intoJul 7, 2026
Merged
Conversation
sbc100
force-pushed
the
html5-dedupe-canvas-resized-callback
branch
from
4234491 to
8d8af19
Compare
sbc100
changed the title
canvasResizedCallback invocations
sbc100
force-pushed
the
html5-dedupe-canvas-resized-callback
branch
from
8d8af19 to
a10d38b
Compare
Extract $callCanvasResizedCallback helper function to unify the 5 separate places where strategy.canvasResizedCallback is called in libhtml5.js. Also initialize $currentFullscreenStrategy to 0 (matching its reset state) so that property access in softFullscreenResizeWebGLRenderTarget is safe.
sbc100
force-pushed
the
html5-dedupe-canvas-resized-callback
branch
from
a10d38b to
8a2a6ca
Compare
sbc100
changed the title
canvasResizedCallback invocationscanvasResizedCallback invocations. NFC
kripken
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
callCanvasResizedCallbackhelper function to unify the 5 separate places wherestrategy.canvasResizedCallbackis called in libhtml5.js.Also, initialize
currentFullscreenStrategyto 0 rather than empty object. This is what it gets reset to inrestoreWindowedStateanyway, so we should be consistent.