[pthread] Honor guard size in pthread_create#27268
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
pthread-guard-size
branch
from
9316c51 to
1b52448
Compare
Honor requested/default guard size in pthread_create by reserving guard_size bytes between thread control data/TSD/TLS and the usable stack. Although we cannot set memory protection on this region like a native platform this can still be useful for catching and reporting overflows that are smaller than the guard region itself. Without this change `-sSTACK_OVERFLOW_CHECK=1` is mostly useless for pthreads because any kind of overflow is likely to corrupt the stack before being reported. Add test cases covering guard size queries via pthread_getattr_np and stack overflow detection within guard region. Fixes: emscripten-core#27266
sbc100
force-pushed
the
pthread-guard-size
branch
from
1b52448 to
c2c362f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor requested/default guard size in pthread_create by reserving guard_size bytes between thread control data/TSD/TLS and the usable stack.
Although we cannot set memory protection on this region like a native platform this can still be useful for catching and reporting overflows that are smaller than the guard region itself. Without this change
-sSTACK_OVERFLOW_CHECK=1is mostly useless for pthreads because any kind of overflow is likely to corrupt the stack before being reported.Add test cases covering guard size queries via pthread_getattr_np and stack overflow detection within guard region.
Fixes: #27266