Apply connect timeout to SOCKS5 handshakes#1091
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
0e326b0 to
87feb69
Compare
|
This is a duplicate of #1017 and also of #1055. Please note that httpcore is not getting active maintenance anymore, unfortunately. There is now httpx2, which is a maintained version, but that has the same problem wrt the proxy timeout!! See pydantic/httpx2#1009 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1089.
Summary
Tests
py -m pytest tests\_sync\test_socks_proxy.py::test_socks5_request_uses_connect_timeout_for_handshake -qpy -m pytest tests\_async\test_socks_proxy.py::test_socks5_request_uses_connect_timeout_for_handshake -qpy -m pytest tests\_sync\test_socks_proxy.py tests\_async\test_socks_proxy.py -quvx ruff==0.5.0 format httpcore tests --diffuvx ruff==0.5.0 check httpcore testspython scripts\unasync.py --checkgit diff --check HEAD~1..HEAD