fix: avoid HTTP healthcheck memory leak#134
Open
tionis wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent an HTTP-based prefix healthcheck from leaking resources over time by reusing an http.Client and ensuring response bodies are fully drained and closed.
Changes:
- Replaced per-probe
http.Getwith a reusablehttp.Client(with timeout) and moved probe logic intocheckHTTP. - Added explicit response-body draining (
io.Copy(io.Discard, ...)) and closing. - Added a unit test to verify the response body is closed for both OK and non-OK status codes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| state/prefix_health.go | Reworks the HTTP healthcheck loop to use a reusable client and explicitly drain/close response bodies. |
| state/prefix_health_test.go | Adds a test to ensure the HTTP healthcheck closes response bodies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+210
to
+215
| resp, err := client.Get(h.URL) | ||
| if err != nil { | ||
| h.lastMetric.Store(INF) | ||
| log.Debug("prefix healthcheck failed", "prefix", h.Prefix.String(), "url", h.URL, "error", err) | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a small memory leak in my setup (roughly 1GB per day).