feat: text layer — search, selection, copy control (1.5.0-beta.13) - #362
Open
endigo wants to merge 3 commits into
Open
feat: text layer — search, selection, copy control (1.5.0-beta.13)#362endigo wants to merge 3 commits into
endigo wants to merge 3 commits into
Conversation
Ports the text-layer work from the wt/text-layer branch onto the federated architecture, fixes the iOS implementation so it compiles, and adds the end-to-end coverage that would have caught it. The iOS code did not build. Three Swift errors, all in the new code: a second `deinit` on FlutterPDFView (the class already had one that removes the same observers); `String? ?? NSNull()`, which is not a valid `??`; and an `if let` on `PDFDocument.index(for:)`, which returns a non-optional Int. That last one also ignored NSNotFound, so a match on a page the document could not resolve would have reported page 0 — now it keeps the default explicitly. None of it was detectable in the original worktree: SwiftPM derives package identity from the directory name, so `flutter build ios` failed at dependency resolution before ever reaching the compiler. Silent failure, fixed. Android returned an empty list from searchText and null from getSelectedText, which is indistinguishable from "this document contains no matches" and "nothing is selected". An app would have shipped broken search without a single error. Now the natives report `kPdfTextLayerUnsupportedCode` and Dart raises UnsupportedError, while `isTextLayerSupported()` lets apps branch before calling. clearSearch and clearSelection stay no-ops, because clearing nothing is truthful. Android is not blocked on upstream, contrary to the original note. PdfiumCore binds none of Pdfium's text API in Java — but the libpdfium inside the same AAR exports 36 FPDFText_* symbols (nm -D, type T, every ABI), including FindStart/FindNext/CountChars/GetText/GetCharBox. Reaching them needs a JNI shim, which is real work but is an option that exists today rather than a wait for a new AndroidPdfViewer. Recorded in the README so the next attempt starts from the right premise. Federated placement: the shared types, settings, callbacks and controller methods live in flutter_pdfview_platform_interface (1.1.0), so a future web or desktop implementation inherits the contract — including the requirement to fail rather than return empty. Verified: 14 new integration tests drive real PDFKit on a simulator (25 total across both suites), against a deterministic fixture with known text on known pages (scripts/make_text_pdf.py). 188 Dart unit tests and 127 Android unit tests pass, iOS and Android example builds succeed, analyze and format clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKmmG2v9eJSWFDLy6mRe8F
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update package and platform-interface docs, replace the generic example README with a demo map, polish the example home screen and TextSearchScreen entry, and extend widget tests. Remove "add search" from future plans.
Owner
Author
|
Follow-up commit: docs + example polish for the text layer.
|
Cover search/selection/copy, isTextLayerSupported, platform notes, and example/integration test pointers for agents working in this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the text layer on top of the federated 1.5.0 stack (
migrate/kotlin-swift/ #345):Versions (not published yet — publish interface first):
flutter_pdfview_platform_interface1.1.0flutter_pdfview1.5.0-beta.13API
Controller
isTextLayerSupported()searchText(query, {caseSensitive})→List<PdfTextMatch>nextMatch/previousMatch/setCurrentMatch/clearSearchgetSelectedText/clearSelectionWidget
enableTextSelection/enableCopy(defaulttrue, live update without remount)onTextSelectionChanged/onSearchResultChangedPlatform support
UnsupportedErrorisTextLayerSupportedtruefalseAndroid has no text layer today: AndroidPdfViewer's
PdfiumCoredoes not bind Pdfium'sFPDFText_*API in Java (even thoughlibpdfiumexports the symbols). Returning empty results would look like “no matches”, so query methods throw and apps should branch onisTextLayerSupported(). A future JNI shim can implement the same interface without Dart API changes.Base
Rebased onto
migrate/kotlin-swift(includes beta.12:spacing+setPage(withAnimation:)). Text-layer changelog is beta.13 so it does not collide with the already-published beta.12.Test plan
flutter analyzeclean (both packages)FlutterPDFViewTextLayerTest+ full suite)example/integration_test/text_layer_test.darton iOS simulator (real PDFKit)enableCopy: falseRelated