fix(german-sysadmin): refer to diacritics as non-ACSII letters#1645
Conversation
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
The German Sysadmin task referred to characters like Ü and ß as non-Latin, however these are Latin characters. Instead, these should be considered non-ASCII. I only updated references that implied Ü/ß were not Latin. I didn't feel compelled to over specify in other cases. When discussing the Latin alphabet, conventional wisdom is that it's simply A-Z, and it's informally accepted to treat it that way. (For example, see the Wikipedia article for Latin.) So the test cases to "allow lowercase Latin letters" or the "whole lowercase Latin alphabet" are fine. Just not anything that outright declares the other characters are not Latin.
angelikatyborska
left a comment
There was a problem hiding this comment.
Thank you very much!
|
Given that the letters like ü and ß are Latin, the test name "Latin" on its own doesn't say which letters are meant. And since the point of the PR is that these letters are Latin, using "Latin alphabet" as shorthand for exactly the 26 feels a little contradictory. Would you be open to renaming the test to explicitly state that it's the 26 letters: It drops the ambiguity without getting pedantic and it reads the same for native and non-native speakers. |
See commit message(s).
I updated the test hints/instructions as they seemed to be explicitly wrong. Stating that diacritics or
ßis non-Latin can be misleading.However, I didn't update the tests as they don't outright say
ßisn't Latin. It just asks for "Latin letters" or the "whole lowercase Latin alphabet" which I believe most people understand this refers to "the 26" letters of the Latin alphabet.It feels a bit contradictory, but I think this is the best route for UX/learners without getting overly pedantic about it.
Related