Skip to content

fix(german-sysadmin): refer to diacritics as non-ACSII letters#1645

Merged
angelikatyborska merged 1 commit into
exercism:mainfrom
SethFalco:issue-1644
Jul 11, 2026
Merged

fix(german-sysadmin): refer to diacritics as non-ACSII letters#1645
angelikatyborska merged 1 commit into
exercism:mainfrom
SethFalco:issue-1644

Conversation

@SethFalco

@SethFalco SethFalco commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

See commit message(s).


I updated the test hints/instructions as they seemed to be explicitly wrong. Stating that diacritics or ß is non-Latin can be misleading.

However, I didn't update the tests as they don't outright say ß isn't Latin. It just asks for "Latin letters" or the "whole lowercase Latin alphabet" which I believe most people understand this refers to "the 26" letters of the Latin alphabet.

It feels a bit contradictory, but I think this is the best route for UX/learners without getting overly pedantic about it.

This modern form is the basis of the Latin script, which is the most widely used writing system in the world, often with diacritics or additional letters beyond the basic 26.

- Latin alphabet (emphasis mine)

Related

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

The German Sysadmin task referred to characters like Ü and ß as
non-Latin, however these are Latin characters. Instead, these should be
considered non-ASCII.

I only updated references that implied Ü/ß were not Latin. I didn't
feel compelled to over specify in other cases. When discussing the Latin
alphabet, conventional wisdom is that it's simply A-Z, and it's
informally accepted to treat it that way. (For example, see the Wikipedia
article for Latin.)

So the test cases to "allow lowercase Latin letters" or the "whole
lowercase Latin alphabet" are fine. Just not anything that outright
declares the other characters are not Latin.

@angelikatyborska angelikatyborska left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@Vukory

Vukory commented Jul 11, 2026

Copy link
Copy Markdown

Given that the letters like ü and ß are Latin, the test name it allows the whole lowercase Latin alphabet becomes ambiguous for anyone whose everyday Latin alphabet includes letters beyond a–z, and the word whole reinforces that, since it implies the complete alphabet. As Bosnian speaker, which Latin alphabet has more than 26 letters, that's how I read it myself.

"Latin" on its own doesn't say which letters are meant. And since the point of the PR is that these letters are Latin, using "Latin alphabet" as shorthand for exactly the 26 feels a little contradictory.

Would you be open to renaming the test to explicitly state that it's the 26 letters: it allows all 26 lowercase Latin characters?

It drops the ambiguity without getting pedantic and it reads the same for native and non-native speakers.

@angelikatyborska
angelikatyborska merged commit 15f2f3c into exercism:main Jul 11, 2026
8 checks passed
@SethFalco
SethFalco deleted the issue-1644 branch July 11, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mistake in german-sysadmin instructions regarding Latin characters

3 participants