storage(lifecycle): use RegisterCLICommand pattern#855
Merged
natalie-o-perret merged 1 commit intoJul 2, 2026
Merged
Conversation
Contributor
Author
|
[SC-187336] |
natalie-o-perret
changed the title
natalie-o-perret
force-pushed
the
natalie-o-perret/lifecycle-struct-pattern
branch
from
8a6f696 to
52f758e
Compare
quentinalbertone
approved these changes
Jul 1, 2026
quentinalbertone
left a comment
quentinalbertone
left a comment
Contributor
There was a problem hiding this comment.
good idea ! Do you think that you can move the storage_bucket_lifecycle* into a subpackage ? You can find an example in the aiservices package
Contributor
Author
I've just signed off, 🚇-typing, but the idea is that we can drive the people using "AI" for external contributions with the AGENTS.md, (#856) file sitting now at the root of the repo. Ironically-speaking, I precisely gave the AI services as an example to develop rule for the LLM to grasp the structure / pattern, and it didn't pick it on its own 😂, I will further adjust the rules there so that next time it picks it up. Good catch anyway, thanks! Addressed |
pierre-emmanuelJ
approved these changes
Jul 1, 2026
2 tasks
natalie-o-perret
added a commit
that referenced
this pull request
Jul 2, 2026
PR #855 refactored storage_bucket_lifecycle* in place, keeping the flat layout in cmd/storage/. Review feedback asked for them to be moved into a subpackage along the lines of cmd/aiservices/deployment/. Add a paragraph to AGENTS.md that names the legacy flat groups and points the agent at the cmd/aiservices/... subpackage layout, with the storage_bucket_lifecycle case as the worked example.
natalie-o-perret
added a commit
that referenced
this pull request
Jul 2, 2026
PR #855 refactored storage_bucket_lifecycle* in place, keeping the flat layout in cmd/storage/. Review feedback asked for them to be moved into a subpackage along the lines of cmd/aiservices/deployment/. Three small tweaks so a future agent picks this up automatically: - Folder layout: add an anti-pattern callout naming the legacy flat groups (cmd/storage, cmd/dns, cmd/dbaas), the cmd/aiservices/deployment subpackage as the canonical pattern, and the storage_bucket_lifecycle case as a worked example. Wording is imperative ("MUST promote"). - Command pattern: cross-ref to Folder layout so an agent starting from the struct pattern doesn't miss the placement cue. - File header rule: parametrize the model name (<model>) instead of hard-coding claude-sonnet-4.6.
natalie-o-perret
force-pushed
the
natalie-o-perret/lifecycle-struct-pattern
branch
from
52f758e to
ead38f6
Compare
natalie-o-perret
added a commit
that referenced
this pull request
Jul 2, 2026
# Description Follow-up to #856. PR #855 refactored `storage_bucket_lifecycle*` in place; review asked to move them into a subpackage per `cmd/aiservices/deployment/`. AGENTS.md missed the placement cue: 3 tweaks so a future agent picks this up automatically: - **Folder layout**: anti-pattern callout naming the legacy flat groups (`cmd/storage`, `cmd/dns`, `cmd/dbaas`), `cmd/aiservices/deployment/` as the canonical subpackage, and `storage_bucket_lifecycle*` as a worked example. Wording imperative (`MUST promote`). - **Command pattern**: cross-ref to Folder layout so an agent starting from the struct pattern doesn't skip placement. - **File header rule**: parametrize the model name (`<model>`) instead of pinning to `claude-sonnet-4.6`. ## Checklist (For exoscale contributors) * [ ] Changelog updated (under *Unreleased* block, and add the Pull Request #number for each bit you add to the `CHANGELOG.md`) * [ ] Testing ## Testing Docs-only. --- > [!NOTE] > AI assistance: PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrites the lifecycle commands to use the struct-based
RegisterCLICommandpattern, consistent with newer commands likecmd/aiservices/deployment/.Changes:
set,show,deleteconverted to typed structs withRegisterCLICommandChecklist
(For exoscale contributors)
CHANGELOG.md)Testing
Build and full test suite pass (
make build && make test-verbose). Lint clean.