feat(book-club): link meeting management from the admin club page (#138)#251
Conversation
…#138) The admin club detail page listed meetings read-only with no path to the edit UI, which lives on the public club page (manager-only inline forms). Uwe asked for meeting editing on /admin/book-club/{id} or at least a link. - admin/show.php: the Meetings section header now carries a 'Manage meetings' link to the club page's meetings section, and every meeting row gets an 'Edit' link that deep-links to that meeting's card (#bc-meeting-<id>), where the inline edit form opens. - public/show.php: the meetings section gains the id="bc-meetings" anchor (per-meeting anchors already existed). - 'Gestisci incontri' added to all four locale catalogues. - book-club plugin bumped to 1.4.2. Verified in a real browser on the local Apache instance: admin page shows both links; 'Edit' lands on the anchored meeting card; the inline form saves (title change persisted to bookclub_meetings); 'Manage meetings' lands on #bc-meetings. PHPStan level 5 clean.
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAggiunge la traduzione di “Gestisci incontri” e collega l’area admin del Book Club alla sezione pubblica degli incontri, includendo link di gestione e modifica tramite anchor dedicati. Aggiorna inoltre la versione del plugin a 1.4.2. ChangesBook Club — gestione incontri
Estimated code review effort: 2 (Simple) | ~10 minuti Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@storage/plugins/book-club/views/admin/show.php`:
- Line 273: Allinea il link “Modifica” nella vista admin show.php agli stati
supportati dal form pubblico: renderizzalo solo quando lo stato dell’incontro è
scheduled, oppure aggiorna esplicitamente la logica del form per consentire done
e cancelled. Mantieni l’anchor invariato per gli incontri modificabili.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b8f95d8d-a8b5-4291-b666-827c72e62231
📒 Files selected for processing (7)
locale/de_DE.jsonlocale/en_US.jsonlocale/fr_FR.jsonlocale/it_IT.jsonstorage/plugins/book-club/plugin.jsonstorage/plugins/book-club/views/admin/show.phpstorage/plugins/book-club/views/public/show.php
… meetings The public club page renders the inline edit form only when a meeting is 'scheduled', so deep-linking Edit from the admin page for done/cancelled meetings landed on an anchor with no form. The link now renders only for editable (scheduled) meetings — verified in a real browser with one meeting per status: only the scheduled row carries the link.
2 participants
Uwe (#138) noted that
/admin/book-club/{id}lists meetings read-only, with no way to edit them or reach the page where they are edited.Changes
#bc-meeting-<id>), where the manager-only inline edit form lives.id="bc-meetings"anchor (per-meeting anchors already existed).Gestisci incontriadded to all four locale catalogues (it/en/de/fr).Verification
Real browser on the local Apache instance (:8081): the admin page renders both links; Edit lands on the anchored meeting card, the inline form opens and a title change persists to
bookclub_meetings; Manage meetings lands on#bc-meetings. PHPStan level 5 clean,php -lclean, locale diff is 4 insertions (no re-ordering).Summary by CodeRabbit
Nuove funzionalità
Localizzazione
Manutenzione