test(logging): port logging suite to pytest style#157
Open
tmgbedu wants to merge 1 commit into
Open
Conversation
Rewrite the logging test module in idiomatic pytest while preserving all 52 tests, their assertions, and subsystem breadth: - unittest.TestCase classes -> plain classes with bare assert - setUpModule/tearDownModule -> module-scoped autouse booted_app fixture - per-class setUp/tearDown -> fixtures (isolated_named_root, snapshot_root) - tempfile.mkstemp/mkdtemp -> tmp_path - redirect_stdout(io.StringIO()) -> capsys - assertRaises -> pytest.raises; assertRegex -> re.search Coverage unchanged at 71.18% (>= 68% gate); full suite green.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the logging test module (
tests/logging/test_logging.py) fromunittestinto idiomatic pytest style, taking the cleaner ergonomics maintainers liked while keeping the current suite's full breadth and mutation-verified assertions.Why
The
unittest-based suite onmainis comprehensive and well-verified, but reads heavier than it needs to (tempfilebookkeeping,redirect_stdout,self.assertX). This ports it to pytest fixtures/assertwithout losing a single test or weakening any assertion.Conversions
unittest.TestCaseclasses → plain classes with bareassertsetUpModule/tearDownModule→ module-scoped autousebooted_appfixturesetUp/tearDown→ fixtures (isolated_named_root, per-classsnapshot_root)tempfile.mkstemp/mkdtemp→tmp_pathredirect_stdout(io.StringIO())→capsysassertRaises→pytest.raises;assertRegex→re.searchGuarantees
fail_undergate.ruff format+ruff checkclean.