docs: README に未記載の Client メソッド2件を追記#284
Merged
Merged
Conversation
- find_sequential_pcd_task_by_name: by name の例を専用メソッドに修正 - get_project_id_slug_map: Get Projects の後に新規追加 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rikunosuke
commented
Jul 17, 2026
Comment on lines
1944
to
1952
| ```python | ||
| task = client.find_sequential_pcd_task(task_id="YOUR_TASK_ID") | ||
| ``` | ||
|
|
||
| Find a single task by name. | ||
|
|
||
| ```python | ||
| task = client.find_sequential_pcd_task(project="YOUR_PROJECT_SLUG", task_name="YOUR_TASK_NAME") | ||
| tasks = client.find_sequential_pcd_task_by_name(project="YOUR_PROJECT_SLUG", task_name="YOUR_TASK_NAME") | ||
| ``` |
Contributor
Author
There was a problem hiding this comment.
おそらくロジック記載ミスと思われるので、修正しています。引数も find_sequential_pcd_task では project/task_name はとらず、これは *_by_name のものでした。
h-iwata
requested changes
Jul 17, 2026
|
|
||
| ```python | ||
| task = client.find_sequential_pcd_task(project="YOUR_PROJECT_SLUG", task_name="YOUR_TASK_NAME") | ||
| tasks = client.find_sequential_pcd_task_by_name(project="YOUR_PROJECT_SLUG", task_name="YOUR_TASK_NAME") |
There was a problem hiding this comment.
返り値がtasks[0]と単数なので、変数名はtaskの方が良さそうですね
ついでに既存のここも直してもらえるとありがたいです
fastlabel-python-sdk/README.md
Line 1756 in 2ce8bbc
Contributor
Author
There was a problem hiding this comment.
ありがとうございます！修正しました！
h-iwata
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
class Client（fastlabel/__init__.py）とREADME.mdを突き合わせた結果、README に記載が漏れていた public メソッド2件を追記しました。変更内容
find_sequential_pcd_task_by_namefind_sequential_pcd_task(project=..., task_name=...)を使っていたため、他フォーマット（例:find_pcd_task_by_name）と同じく専用メソッドを使う形に修正get_project_id_slug_mapget_task_id_name_mapの記載スタイルに準拠いずれも README 既存のセクション構成・見出しレベル・コードブロックのスタイルに従っています。これで
Clientの public メソッドはすべて README でカバーされました。🤖 Generated with Claude Code