Support parsing of <!--esi ...--> comments - #57
Merged
Conversation
- Implement parsing for <!--esi ...--> comments, stripping delimiters and processing inner ESI content. - Add tests for various scenarios including plain HTML, variables, choose statements, and mixed comments. Fixes #48
acme
approved these changes
Jul 27, 2026
acme
left a comment
acme
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks good.
Minor: strip_prefix(b"esi") has no boundary after esi, so <!--esitest--> gets treated as ESI and renders as test. Intentional or should we match tighter? Either way, worth a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement parsing for ESI comment blocks, allowing the library to process inner ESI content while stripping the comment delimiters. This enhancement includes comprehensive tests for various scenarios, ensuring correct handling of plain HTML, variables, choose statements, and mixed comments.
Fixes #48