Treat subdomains of the site host as internal links - #7
Merged
Conversation
etagwerker
approved these changes
Jul 31, 2026
etagwerker
left a comment
Member
There was a problem hiding this comment.
@julioalucero Good idea. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira
FR-767: Sibling subdomains get rel="nofollow" as if they were external links
PR description
SEMrush flagged 12 internal links across 9 pages of the FastRuby.io blog as
nofollow. Thenofollowisn't in the Jekyll sources, this gem adds it at build time:external_link?compared hosts exactly, so withurl: https://www.fastruby.iothe site host isfastruby.ioandaudit.fastruby.io/skunk.fastruby.iocame out external. SEMrush counts subdomains as the same site. v0.2.0 already fixed thewww.case, subdomains were the remaining gap.external_link?inlib/jekyll-external-link-accessibility.rb: a host ending in.<site_host>is internalnotfastruby.ioexternal.fastruby.github.iostays external too, which matters because a post links to itsite_hostbeing present, otherwise a site with nourlwould compare against"."VERSIONto0.3.0(plusGemfile.lock)After this is released, the blog repo needs the gem bumped in
Gemfile/Gemfile.lock/Gemfile.next.lock, andour_hostsinblog/spec/blog_spec.rbwidened to any*.fastruby.iohost so the same thing can't slip through again.QA steps
3Build the blog against this branch and confirm no
nofollowon*.fastruby.iolinks, e.g./blog/open-source-tooling.htmlhad 3 of them