Skip to content

fix: match audio and video extensions case-insensitively #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dhevenddra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: match audio and video extensions case-insensitively #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fish_audio_preprocess/cli/merge_lab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ def merge_lab(
recursive: bool,
):
audio_files = list_files(input_dir, recursive=recursive)
audio_files = [str(file) for file in audio_files if file.suffix in AUDIO_EXTENSIONS]
audio_files = [
str(file) for file in audio_files if file.suffix.lower() in AUDIO_EXTENSIONS
]
results = []
for audio_file in tqdm(audio_files):
# logger.info(f"Processing {audio_file}")
Expand Down
4 changes: 3 additions & 1 deletion fish_audio_preprocess/cli/transcribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ def transcribe(
logger.info(f"Transcribing audio files in {input_dir}")
# 扫描出所有的音频文件
audio_files = list_files(input_dir, recursive=recursive)
audio_files = [str(file) for file in audio_files if file.suffix in AUDIO_EXTENSIONS]
audio_files = [
str(file) for file in audio_files if file.suffix.lower() in AUDIO_EXTENSIONS
]

if len(audio_files) == 0:
logger.error(f"No audio files found in {input_dir}.")
Expand Down
6 changes: 5 additions & 1 deletion fish_audio_preprocess/utils/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ def list_files(
)

if extensions is not None:
files = [f for f in files if f.suffix in extensions]
# Match case-insensitively. Recorders, cameras and phones routinely
# write .WAV/.MP3/.MP4, and Path.suffix preserves that case, so an
# exact match silently skipped those files.
extensions = {ext.lower() for ext in extensions}
files = [f for f in files if f.suffix.lower() in extensions]

if sort:
files = sorted(files)
Expand Down