Prepare composition-cli for its first npm release - #294
Merged
Conversation
…to 0.29.0 The composition version in manifest v1 was hardcoded, and bump-version.sh only rewrites package.json version fields, so every release left it stale. Deriving it from the CLI's own version keeps it correct without a manual step. Also sets fail-fast: false on the release matrix so one package's publish failure no longer cancels the others.
PiotrWodecki
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@fishjam-cloud/composition-clifrom0.29.0-rc.2to0.29.0, in line with the rest of the repo.Manifest v1 hardcoded
@fishjam-cloud/composition: 0.29.0-rc.2inscaffoldDevDependencies.bump-version.shonly rewritespackage.jsonversion fields, so that string was invisible to the release automation and every release would leave it pointing at an old version. It fails quietly too: the stale version still installs, so a scaffolded template just silently gets an rc.Fishjam deps are now listed in
scaffoldCliVersionDevDependenciesand pinned to the CLI's own version at scaffold time. The repo is versioned in lockstep, so that is the right number. Added a test that fails if anyone hardcodes a@fishjam-cloud/*version in the manifest again.Also sets
fail-fast: falseon the release matrix. The three packages are independent npm publishes, and today one failure cancels the others mid-release.Note:
@fishjam-cloud/composition-clidoes not exist on npm yet, and the release workflow publishes via OIDC trusted publishing, which is configured per package. The first publish needs to be done manually, as was done for@fishjam-cloud/composition.