Skip to content

FCE-3728 / add recordings methods - #295

Merged
czerwiukk merged 4 commits into
mainfrom
FCE-3728/add-recordings-methods
Aug 14, 2026
Merged

FCE-3728 / add recordings methods#295
czerwiukk merged 4 commits into
mainfrom
FCE-3728/add-recordings-methods

Conversation

@czerwiukk

Copy link
Copy Markdown
Member

Description

Adds recording methods and notification types.

Motivation and Context

Allows to use recordings with this SDK.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@czerwiukk
czerwiukk requested review from Karolk99 and a balanced review from Copilot August 13, 2026 13:14
@czerwiukk czerwiukk self-assigned this Aug 13, 2026
@linear

linear Bot commented Aug 13, 2026

Copy link
Copy Markdown

FCE-3728

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds recording lifecycle support to the server SDK, backed by refreshed OpenAPI models and recording notifications.

Changes:

  • Adds create, retrieve, list, stop, and delete recording methods.
  • Adds recording types, status notifications, and recording-specific exceptions.
  • Updates generated OpenAPI code and recording-related tests.

Reviewed changes

Copilot reviewed 10 out of 73 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Adds a notifier workspace resolution.
packages/js-server-sdk/tests/notifications.test.ts Tests recording notifications.
packages/js-server-sdk/tests/client.test.ts Tests recording client methods.
packages/js-server-sdk/src/types.ts Adds recording SDK types.
packages/js-server-sdk/src/notifications.ts Maps recording status notifications.
packages/js-server-sdk/src/index.ts Exports recording APIs and types.
packages/js-server-sdk/src/exceptions/mapper.ts Maps recording 404 errors.
packages/js-server-sdk/src/exceptions/index.ts Adds recording-not-found exception.
packages/js-server-sdk/src/client.ts Adds recording management methods.
packages/fishjam-openapi/src/generated/models/ViewerToken.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/ViewerDetailsResponse.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/Viewer.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/VideoCodec.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/TrackType.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/TrackForwardingInfo.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/TrackForwarding.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/Track.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/Subscriptions.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/SubscribeTracksRequest.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/SubscribeMode.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/StreamsListingResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/StreamerToken.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/StreamerDetailsResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/Streamer.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/StreamDetailsResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/StreamConfig.ts Refreshes generated config.
packages/fishjam-openapi/src/generated/models/Stream.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/RoomType.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/RoomsListingResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/RoomDetailsResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/RoomCreateDetailsResponseData.ts Refreshes generated response data.
packages/fishjam-openapi/src/generated/models/RoomCreateDetailsResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/RoomConfig.ts Refreshes generated config.
packages/fishjam-openapi/src/generated/models/Room.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/RecordingStatus.ts Adds the finished recording status.
packages/fishjam-openapi/src/generated/models/RecordingSource.ts Refreshes recording source model.
packages/fishjam-openapi/src/generated/models/RecordingListResponse.ts Refreshes recording list response.
packages/fishjam-openapi/src/generated/models/RecordingDetailsResponse.ts Refreshes recording response.
packages/fishjam-openapi/src/generated/models/RecordingConfig.ts Refreshes recording config.
packages/fishjam-openapi/src/generated/models/Recording.ts Refreshes recording model.
packages/fishjam-openapi/src/generated/models/PeerType.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/PeerStatus.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/PeerRefreshTokenResponseData.ts Refreshes generated response data.
packages/fishjam-openapi/src/generated/models/PeerRefreshTokenResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/PeerOptionsWebRTC.ts Refreshes peer options.
packages/fishjam-openapi/src/generated/models/PeerOptionsVapi.ts Refreshes peer options.
packages/fishjam-openapi/src/generated/models/PeerOptionsAgent.ts Refreshes peer options.
packages/fishjam-openapi/src/generated/models/PeerDetailsResponseData.ts Refreshes generated response data.
packages/fishjam-openapi/src/generated/models/PeerDetailsResponse.ts Refreshes generated response.
packages/fishjam-openapi/src/generated/models/PeerConfigWebRTC.ts Refreshes peer config.
packages/fishjam-openapi/src/generated/models/PeerConfigVAPI.ts Refreshes peer config.
packages/fishjam-openapi/src/generated/models/PeerConfigAgent.ts Refreshes peer config.
packages/fishjam-openapi/src/generated/models/PeerConfig.ts Refreshes peer config union.
packages/fishjam-openapi/src/generated/models/Peer.ts Refreshes generated model.
packages/fishjam-openapi/src/generated/models/MoqAccessConfig.ts Refreshes MoQ config.
packages/fishjam-openapi/src/generated/models/MoqAccess.ts Refreshes MoQ model.
packages/fishjam-openapi/src/generated/models/ModelError.ts Refreshes generated error model.
packages/fishjam-openapi/src/generated/models/CompositionSource.ts Refreshes composition source.
packages/fishjam-openapi/src/generated/models/CompositionInfo.ts Refreshes composition model.
packages/fishjam-openapi/src/generated/models/AudioSampleRate.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/AudioFormat.ts Refreshes generated enum.
packages/fishjam-openapi/src/generated/models/AgentOutput.ts Refreshes agent output model.
packages/fishjam-openapi/src/generated/apis/ViewersApi.ts Refreshes generated viewers API.
packages/fishjam-openapi/src/generated/apis/TrackForwardingsApi.ts Refreshes track-forwarding API.
packages/fishjam-openapi/src/generated/apis/StreamersApi.ts Refreshes generated streamers API.
packages/fishjam-openapi/src/generated/apis/MoQApi.ts Refreshes generated MoQ API.
packages/fishjam-openapi/src/generated/apis/CredentialsApi.ts Refreshes generated credentials API.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/js-server-sdk/src/notifications.ts Outdated
Comment thread packages/js-server-sdk/src/notifications.ts Outdated
@czerwiukk
czerwiukk merged commit c83334b into main Aug 14, 2026
2 checks passed
@czerwiukk
czerwiukk deleted the FCE-3728/add-recordings-methods branch August 14, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants