Skip to content

Add recording status notification - #59

Merged
czerwiukk merged 1 commit into
masterfrom
fce-3518
Aug 12, 2026
Merged

Add recording status notification#59
czerwiukk merged 1 commit into
masterfrom
fce-3518

Conversation

@roznawsk

Copy link
Copy Markdown
Contributor

Adds RecordingStatusChanged to ServerMessage so Fishjam can push recording lifecycle transitions (finished/available/failed) with the recording's metadata to the dashboard webhook, per ADR-0048.

No ACTIVE value — recordings are born active (that's the create response, not a transition).

Part of FCE-3518.

@linear

linear Bot commented Jul 30, 2026

Copy link
Copy Markdown

FCE-3518

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new server notification message to expose recording lifecycle transitions to webhook consumers (dashboard), aligning the protobuf schema, generated Elixir bindings, and rendered docs.

Changes:

  • Introduces ServerMessage.RecordingStatusChanged with Status enum (FINISHED/AVAILABLE/FAILED) plus recording_id and metadata.
  • Adds recording_status_changed as a new ServerMessage oneof content variant (tag 34).
  • Regenerates/updates Elixir protobuf modules and the markdown docs to include the new message and enum.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
fishjam/server_notifications.proto Adds RecordingStatusChanged message + ServerMessage oneof variant for recording status transitions.
fishjam_protos/lib/fishjam/server_notifications.pb.ex Updates generated Elixir protobuf definitions to include the new enum/message and field.
doc/docs.md Updates generated documentation/TOC to document the new notification and enum.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roznawsk
roznawsk requested a review from czerwiukk July 31, 2026 11:13
@czerwiukk
czerwiukk merged commit 0bbd9f0 into master Aug 12, 2026
5 checks passed
@czerwiukk
czerwiukk deleted the fce-3518 branch August 12, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants