FCE-3589: peer views and sandbox move behind the tsunami core - #596
Open
MiloszFilimowski wants to merge 1 commit into
Open
FCE-3589: peer views and sandbox move behind the tsunami core#596MiloszFilimowski wants to merge 1 commit into
MiloszFilimowski wants to merge 1 commit into
Conversation
peerViews derives the localPeer/remotePeers track views (camera, microphone, screen-share, custom tracks per peer) from ClientState, so usePeers becomes a thin adapter. The sandbox HTTP helpers and fishjam URL resolution move into tsunami (single implementation for all framework consumers); react-client's useSandbox delegates to them and its local fishjamUrl/errors utilities are deleted.
MiloszFilimowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #595.
Description
state/peerViews.ts: derives the local/remote peer track views (camera, microphone, screen-share, custom tracks per peer) fromClientState, sousePeersbecomes a thin adapter over the store.useSandboxdelegates and its localfishjamUrl/errorsutilities are deleted.Motivation and Context
Continues the hook-thinning of FCE-3589: view derivation belongs to the core so non-React consumers get identical peer views.
Documentation impact
Types of changes
not work as expected)