FCE-3592: deviceManager injection points and platform-owned stream construction - #599
Open
MiloszFilimowski wants to merge 2 commits into
Open
FCE-3592: deviceManager injection points and platform-owned stream construction#599MiloszFilimowski wants to merge 2 commits into
MiloszFilimowski wants to merge 2 commits into
Conversation
…injection points An injected manager owns persistence (persistLastDevice is skipped entirely), which is what lets mobile drop its localStorage polyfill later. clientType flows through the tsunami config into ts-client, so mobile can stop constructing a signalling client of its own.
…undary IDeviceManager grows createMediaStream; the controller exposes a render-ready stream scoped to the active track (the shared initializeDevices stream never leaks the other kind's track into a preview), and useCamera/useMicrophone/ useLivestreamStreamer stop calling the MediaStream global. The global now survives only for the legacy ts-client/webrtc-client core.
MiloszFilimowski
changed the title
6 tasks
MiloszFilimowski
marked this pull request as ready for review
August 11, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #598.
Description
FishjamProvidergainsdeviceManagerandclientTypeinjection points; an injected manager owns persistence (thepersistLastDevicebranch is skipped entirely — which is what makes mobile's localStorage polyfill removable in FCE-3592: mobile runs on ReactNativeDeviceManager, polyfill diet #600).IDeviceManager.createMediaStream: stream construction moves behind the platform boundary.TrackDeviceControllerexposes a render-ready stream scoped to the active track —initializeDevicesshares one stream across camera+mic, so a naive passthrough would leak the other kind into a preview.useCamera/useMicrophone/useLivestreamStreamerno longer touch theMediaStreamglobal.deviceManagerInjectionspecs (+2) pin the injection behavior.Motivation and Context
The injection points that let the mobile provider run on a native device manager (#600), per the FCE-3592 decision.
Documentation impact
Types of changes
not work as expected)