chore: stop ignoring inline doc stubs (.*.md) - #263
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates ChangesDocumentation tracking
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
oleg-flamingocx
added a commit
that referenced
this pull request
Jul 28, 2026
Pre-resolve the develop->main doc conflicts on develop so the eventual merge into main is clean. main's #263/#264 (automated Technical Writer) restructured the docs and regenerated README/docs; those changes are absorbed here, except for four files kept at develop's versions because develop's are newer and reflect shipped GKE/cloud features main lacks: - README.md - docs/README.md - docs/development/setup/local-development.md - docs/architecture/decisions.md (bot deleted it; kept as it is a substantive hand-written architecture doc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
.*.mdrule from.gitignoreand replaces it with a loud comment telling future contributors not to re-add it.Why
#212added:Two problems with that:
1. The inline doc stubs are supposed to be committed. They're per-file documentation written next to the source they describe, generated by the Flamingo AI Technical Writer. They belong in the repo and in the PR diff, reviewed alongside the code. Ignoring them silently discards the output of every documentation run.
2. It hard-failed the whole workflow.
.*.mdalso matched the orchestrator's own run status file, so the job died at branch creation, before a single doc was generated:See run #30206764288.
Reviewer notes
Summary by CodeRabbit