fix: align index loading with upstream Helm v4 - #2120
Merged
Conversation
stefanprodan
added
bug
stefanprodan
commented
Aug 4, 2026
| sem := semaphore.NewWeighted(current) | ||
| c := &chartWithLock{Chart: c} | ||
| for name, dep := range deps { | ||
| name, dep := name, dep |
Member
Author
There was a problem hiding this comment.
Since Go 1.22 iteration gets a fresh copy of the loop variables. At some point we'll need to do a sweep of all Flux source code and simplify.
matheuscscp
approved these changes
Aug 4, 2026
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
index-loading-helmv4
branch
from
August 4, 2026 17:02
e8b256e to
ded4718
Compare
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove empty entries from the versions list in
IndexFromBytesthe same way Helm'sloadIndexdoes. As defense in depth, recover panics in theDependencyManagerbuild as errors and log the invalid entries.