feat: scoped accounts - #181
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🛑 Changes requested — automated reviewThe changed instruction encoding is incompatible with existing bytecode but is still labeled as format v2, allowing silent misdecoding or runtime panics across versions. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #181 (comment)
| return err | ||
| } | ||
|
|
||
| a.emit(vm.Op_Save, account, asset, amount) |
There was a problem hiding this comment.
🔴 [blocker] Bump the bytecode format version for changed opcode layouts
Adding mandatory extension words to existing opcodes such as Save, metadata reads, and Balance changes the v2 instruction layout, but FormatVersion remains 2. Consequently, the new decoder accepts old v2 bytecode and the VM consumes the following real instruction as an extension word (or reads past the end), while older runtimes also accept newly emitted v2 files but misinterpret their extensions. Increment the format version so incompatible bytecode is rejected.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/exp/vm #181 +/- ##
==============================================
Coverage ? 57.75%
==============================================
Files ? 83
Lines ? 10839
Branches ? 0
==============================================
Hits ? 6260
Misses ? 4202
Partials ? 377 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.