test(e2e): poll for grpcapi service deletion instead of kubectl wait - #509
Closed
Dav-14 wants to merge 1 commit into
Closed
test(e2e): poll for grpcapi service deletion instead of kubectl wait#509Dav-14 wants to merge 1 commit into
Dav-14 wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kubectl wait --for=delete can ignore --timeout and hang until chainsaw's step timeout kills the script (signal: killed), which flaked the gateway-grpcapi-sync deletion step on the K8s 1.31 runner. Replace it with a bounded kubectl get poll so the assertion fails legibly if the service is genuinely not garbage-collected.
Dav-14
force-pushed
the
test/grpcapi-deletion-wait
branch
from
August 3, 2026 10:10
2fd150a to
b4c413f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubectl wait --for=delete can ignore --timeout and hang until chainsaw's
step timeout kills the script (signal: killed), which flaked the
gateway-grpcapi-sync deletion step on the K8s 1.31 runner. Replace it
with a bounded kubectl get poll so the assertion fails legibly if the
service is genuinely not garbage-collected.
Stack created with GitHub Stacks CLI • Give Feedback 💬