fix(connectivity): report pending when ledger Credentials API is unavailable - #516
Closed
Dav-14 wants to merge 1 commit into
Closed
fix(connectivity): report pending when ledger Credentials API is unavailable#516Dav-14 wants to merge 1 commit into
Dav-14 wants to merge 1 commit into
Conversation
…ailable A missing ledger Credentials CRD (NoMatch) or absent RBAC (Forbidden) — e.g. an older ledger operator that predates the Credentials API — was surfaced as a hard reconcile failure (LedgerCredentialsFailed). Treat it as an external capability gap instead: set a LedgerCredentialsUnavailable condition and return a pending error so the module reports unavailable and retries once the ledger operator provides the capability, mirroring the connectivity operator gate. Addresses NumaryBot finding 4132b30d8cdd379d.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by #492, which includes this fix with the polling fallback and expanded tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing ledger Credentials CRD (NoMatch) or absent RBAC (Forbidden) — e.g.
an older ledger operator that predates the Credentials API — was surfaced as a
hard reconcile failure (LedgerCredentialsFailed). Treat it as an external
capability gap instead: set a LedgerCredentialsUnavailable condition and return
a pending error so the module reports unavailable and retries once the ledger
operator provides the capability, mirroring the connectivity operator gate.
Addresses NumaryBot finding 4132b30d8cdd379d.
Stack created with GitHub Stacks CLI • Give Feedback 💬