Skip to content

fix(connectivity): dial ledger v3 gRPC by Service name, not TLS SNI - #517

Closed
Dav-14 wants to merge 1 commit into
fix/connectivity-credentials-pendingfrom
fix/connectivity-ledger-address
Closed

fix(connectivity): dial ledger v3 gRPC by Service name, not TLS SNI#517
Dav-14 wants to merge 1 commit into
fix/connectivity-credentials-pendingfrom
fix/connectivity-ledger-address

Conversation

@Dav-14

@Dav-14 Dav-14 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

ledgerAddress was built from backend.TLS.ServerName, the SNI/certificate FQDN
(ledger-..svc.cluster.local). On clusters whose DNS domain is not
cluster.local that FQDN need not resolve, so connectivity-core could not reach
the ledger. Build the dial address from backend.Name — the Service name, which
resolves in the stack namespace on any DNS domain — and keep TLS.ServerName as
the SNI on spec.ledgerTLS for certificate verification, mirroring how the gateway
upstream dials its backend.

Addresses NumaryBot finding 52f0f4a930fa3d33.


Stack created with GitHub Stacks CLIGive Feedback 💬

ledgerAddress was built from backend.TLS.ServerName, the SNI/certificate FQDN
(ledger-<stack>.<stack>.svc.cluster.local). On clusters whose DNS domain is not
cluster.local that FQDN need not resolve, so connectivity-core could not reach
the ledger. Build the dial address from backend.Name — the Service name, which
resolves in the stack namespace on any DNS domain — and keep TLS.ServerName as
the SNI on spec.ledgerTLS for certificate verification, mirroring how the gateway
upstream dials its backend.

Addresses NumaryBot finding 52f0f4a930fa3d33.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c7d164a5-79c2-4e94-a341-3cb7b93d210a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Dav-14

Dav-14 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #492, which includes this fix and verifies the Service dial address while preserving the TLS SNI.

@Dav-14 Dav-14 closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant