F-115: Hilt Path A engine fix + NiA dogfood docs - #232
Merged
Conversation
Forward processorConfigurationFeatures from host DSLs into applyTargetPlugins so targetPlugin companion .ksp deps create the ksp configuration (Hilt Path A). Document green external spike (hiltImpl/hiltApp/hiltAndroidUtil/hiltBinary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyTargetPluginsaccepts optionalconfigurationFeaturesand forwards it when applying type-owned companion deps. Wired onimpl/androidApp/androidUtil/uiLibrary/library/androidBinary.targetPlugin(..., dependencies = hilt + compiler.ksp)) failed withConfiguration with name 'ksp' not foundbecause companion deps bypassed the host DSL’s KSP bootstrap./Users/claw/work/nowinandroid-forma/forma-spike— Path AhiltImpl/hiltApp/hiltAndroidUtil/hiltBinary,@HiltAndroidAppon binary, features on Hilt VMs, noimpl→impl.DOGFOOD-NIA.mdphase C Hilt + findings F12/F13; TICKETS/PROGRESS/TARGET-PLUGINS.Verify
plugins/./gradlew :deps:test publishAllToMavenLocal -PformaLocalVersion=0.1.3-NIA→ BUILD SUCCESSFUL./gradlew :binary:assembleDebug→ BUILD SUCCESSFUL (242 tasks; Hilt aggregate/compile green); APK ~9.4MBTicket
F-115 still
in_progress— next: Room / more features. F-094 still blocked human.