Fix value concatenation for functionality - #186
Merged
Merged
Conversation
Fix: concat the values, to make it work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way MSBuild parameters are constructed and passed in the
Invoke-FSCCompilefunction to improve flexibility and maintainability. The main change is to consolidate all required and optional MSBuild parameters into a single string, ensuring that both default and user-supplied parameters are consistently applied.MSBuild parameter handling:
$msBuildParametersstring by including all required/p:parameters (BuildTasksDirectory,MetadataDirectory,FrameworkDirectory,ReferencePath,OutputDirectory), and appends any additional parameters specified in$settings.msBuildParameters./p:parameters directly to the-Pargument ofInvoke-MsBuild, ensuring all parameters are passed only through-MsBuildParameters.These changes simplify parameter management and reduce the risk of missing or conflicting MSBuild arguments.